From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91442C433E0 for ; Thu, 28 May 2020 14:27:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6EB272084C for ; Thu, 28 May 2020 14:27:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590676035; bh=HGe4Jo4TLnA1w0mekGRSXAahnApr+MBQk+vZ/U/T20w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=XXiM7VaDH74erCWbsTVd/Gzz5qk8WjcHGtzeM82ss08OVHFKTRQcO/rAFhURfyv7G GroGGjy14RxQbavNf5xAFcuw6bbtaH4+dlIBuNgpC8nxWFiBB8apxHFrvfgf5fvjDi F4bCBaP4k2nrtdzFggsntORiGkXfS/b42O7ELv6U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391135AbgE1O1O (ORCPT ); Thu, 28 May 2020 10:27:14 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:44430 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390932AbgE1O1K (ORCPT ); Thu, 28 May 2020 10:27:10 -0400 Received: by mail-pg1-f194.google.com with SMTP id p30so13529655pgl.11; Thu, 28 May 2020 07:27:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=I3QwPwj57vR622OFwPIZLJsqn8CMDVU9+E93zXZEl7w=; b=qk2qF0gQl1z3vSNVe7c0miFu+Fv06RjIgOPGwpsA6EqB/lzPEFbxqUs+q6x9Hx8C1R nf4Kw8/nAYceQgMnVl/f+a2bBUbSXtT+Yp+lYiG1feUYNW5xTBc0Au0Q4DVhfoEdDDHq nnEgWlyMROeBAuVkeK21id+xZLCiKXNryyXiAq0p6neFFGTkcsL5ql3XSsk+hq166HzA bhx21qN7yJUsS4BbqpbYrvhr117bGnurqXkfHiV3e8qP3pDhDpYNfLSblej9ECE/MO+H tSH53fpdbXuHtuhD+LTCrONzi+F/cCd8sg6E8gViVE6zEX4GFuwtSx70T+FN4FuizQt9 DiNg== X-Gm-Message-State: AOAM533oHVKV4KC7dXiv1Ri+/7VHYUWHiInOxgTJE4r72zYU3JVvY8zr 10UkQaDF9FrrSqmO7VfsK5U= X-Google-Smtp-Source: ABdhPJzQ/Wl12yloNf3ZZaN9rKmvwL5WadQ0KBAb2qHNvFuUSn40gW7K9nUkh40DDMB3iTewQHCqsw== X-Received: by 2002:a65:4487:: with SMTP id l7mr3265836pgq.221.1590676029048; Thu, 28 May 2020 07:27:09 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id x21sm1837134pff.6.2020.05.28.07.27.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 May 2020 07:27:07 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id C5BF340605; Thu, 28 May 2020 14:27:05 +0000 (UTC) Date: Thu, 28 May 2020 14:27:05 +0000 From: Luis Chamberlain To: Jakub Kicinski Cc: jeyu@kernel.org, davem@davemloft.net, michael.chan@broadcom.com, dchickles@marvell.com, sburla@marvell.com, fmanlunas@marvell.com, aelior@marvell.com, GR-everest-linux-l2@marvell.com, kvalo@codeaurora.org, johannes@sipsolutions.net, akpm@linux-foundation.org, arnd@arndb.de, rostedt@goodmis.org, mingo@redhat.com, aquini@redhat.com, cai@lca.pw, dyoung@redhat.com, bhe@redhat.com, peterz@infradead.org, tglx@linutronix.de, gpiccoli@canonical.com, pmladek@suse.com, tiwai@suse.de, schlad@suse.de, andriy.shevchenko@linux.intel.com, derosier@gmail.com, keescook@chromium.org, daniel.vetter@ffwll.ch, will@kernel.org, mchehab+samsung@kernel.org, vkoul@kernel.org, mchehab+huawei@kernel.org, robh@kernel.org, mhiramat@kernel.org, sfr@canb.auug.org.au, linux@dominikbrodowski.net, glider@google.com, paulmck@kernel.org, elver@google.com, bauerman@linux.ibm.com, yamada.masahiro@socionext.com, samitolvanen@google.com, yzaikin@google.com, dvyukov@google.com, rdunlap@infradead.org, corbet@lwn.net, dianders@chromium.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH v3 0/8] kernel: taint when the driver firmware crashes Message-ID: <20200528142705.GQ11244@42.do-not-panic.com> References: <20200526145815.6415-1-mcgrof@kernel.org> <20200526154606.6a2be01f@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> <20200526230748.GS11244@42.do-not-panic.com> <20200526163031.5c43fc1d@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> <20200527031918.GU11244@42.do-not-panic.com> <20200527143642.5e4ffba0@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200527143642.5e4ffba0@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 27, 2020 at 02:36:42PM -0700, Jakub Kicinski wrote: > On Wed, 27 May 2020 03:19:18 +0000 Luis Chamberlain wrote: > > I read your patch, and granted, I will accept I was under the incorrect > > assumption that this can only be used by networking devices, however it > > the devlink approach achieves getting userspace the ability with > > iproute2 devlink util to query a device health, on to which we can peg > > firmware health. But *this* patch series is not about health status and > > letting users query it, its about a *critical* situation which has come up > > with firmware requiring me to reboot my system, and the lack of *any* > > infrastructure in the kernel today to inform userspace about it. > > > > So say we use netlink to report a critical health situation, how are we > > informing userspace with your patch series about requring a reboot? > > One of main features of netlink is pub/sub model of notifications. > > Whatever you imagine listening to your uevent can listen to > devlink-health notifications via devlink. > > In fact I've shown this off in the RFC patches I sent to you, see > the devlink mon health command being used. Yes but I looked at iputils2 devlink and seems I made an incorrect assumption this can only be used for a network device rather than a struct device. I'll take a second look. Luis