From: Jonathan Cameron <jic23@kernel.org>
To: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>
Cc: "rikard.falkeborn@gmail.com" <rikard.falkeborn@gmail.com>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"Hennerich, Michael" <Michael.Hennerich@analog.com>,
"knaack.h@gmx.de" <knaack.h@gmx.de>,
"lars@metafoo.de" <lars@metafoo.de>,
"pmeerw@pmeerw.net" <pmeerw@pmeerw.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/6] iio: dac: ad5380: Constify struct iio_chan_spec_ext_info
Date: Sun, 31 May 2020 14:44:16 +0100 [thread overview]
Message-ID: <20200531144416.33dbff82@archlinux> (raw)
In-Reply-To: <dfbaa1863b7bc3f69a184bb4d7b7ee7805f06e88.camel@analog.com>
On Wed, 27 May 2020 04:22:30 +0000
"Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote:
> On Tue, 2020-05-26 at 23:02 +0200, Rikard Falkeborn wrote:
> > [External]
> >
> > ad5380_ext_info is not modified and can be made const to allow the
> > compiler to put it in read-only memory.
> >
> > Before:
> > text data bss dec hex filename
> > 12060 3280 192 15532 3cac drivers/iio/dac/ad5380.o
> >
> > After:
> > text data bss dec hex filename
> > 12252 3088 192 15532 3cac drivers/iio/dac/ad5380.o
> >
>
> Acked-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
>
Applied.
> > Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
> > ---
> > drivers/iio/dac/ad5380.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/dac/ad5380.c b/drivers/iio/dac/ad5380.c
> > index b37e5675f716..04c74cc1a4ec 100644
> > --- a/drivers/iio/dac/ad5380.c
> > +++ b/drivers/iio/dac/ad5380.c
> > @@ -240,7 +240,7 @@ static const struct iio_info ad5380_info = {
> > .write_raw = ad5380_write_raw,
> > };
> >
> > -static struct iio_chan_spec_ext_info ad5380_ext_info[] = {
> > +static const struct iio_chan_spec_ext_info ad5380_ext_info[] = {
> > {
> > .name = "powerdown",
> > .read = ad5380_read_dac_powerdown,
next prev parent reply other threads:[~2020-05-31 13:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 21:02 [PATCH 0/6] drivers/iio: Constify structs Rikard Falkeborn
2020-05-26 21:02 ` [PATCH 1/6] iio: adc: max11100: Constify struct iio_chan_spec Rikard Falkeborn
2020-05-31 13:07 ` Jonathan Cameron
2020-05-26 21:02 ` [PATCH 2/6] iio: dac: ad5380: Constify struct iio_chan_spec_ext_info Rikard Falkeborn
2020-05-27 4:22 ` Ardelean, Alexandru
2020-05-31 13:44 ` Jonathan Cameron [this message]
2020-05-26 21:02 ` [PATCH 3/6] iio: dac: ad5592r-base: " Rikard Falkeborn
2020-05-27 4:22 ` Ardelean, Alexandru
2020-05-31 13:47 ` Jonathan Cameron
2020-05-26 21:02 ` [PATCH 4/6] iio: dac: ad5686: Constify static struct iio_chan_spec Rikard Falkeborn
2020-05-27 4:50 ` Ardelean, Alexandru
2020-05-31 13:47 ` Jonathan Cameron
2020-08-18 19:30 ` Rikard Falkeborn
2020-08-22 10:31 ` Jonathan Cameron
2020-05-26 21:02 ` [PATCH 5/6] iio: light: stk3310: Constify regmap_config Rikard Falkeborn
2020-05-31 13:47 ` Jonathan Cameron
2020-05-26 21:02 ` [PATCH 6/6] iio: magnetometer: mmc35240: Constify struct reg_default Rikard Falkeborn
2020-05-31 13:48 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200531144416.33dbff82@archlinux \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=alexandru.Ardelean@analog.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=rikard.falkeborn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).