From: Nathan Chancellor <natechancellor@gmail.com>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [git pull] misc uaccess stuff
Date: Wed, 3 Jun 2020 13:44:39 -0700 [thread overview]
Message-ID: <20200603204439.GA2649647@ubuntu-n2-xlarge-x86> (raw)
In-Reply-To: <20200603192306.GX23230@ZenIV.linux.org.uk>
On Wed, Jun 03, 2020 at 08:23:06PM +0100, Al Viro wrote:
> uaccess patches that really didn't fit anywhere else.
> kvm_hv_set_msr() patch left as-is; __put_user() is by no means
> final there, but that'll be dealt with along with other KVM
> uaccess stuff next cycle.
>
> The following changes since commit b44f687386875b714dae2afa768e73401e45c21c:
>
> drm/i915/gem: Replace user_access_begin by user_write_access_begin (2020-05-01 12:35:22 +1000)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git uaccess.misc
>
> for you to fetch changes up to 4ec76a2b74c72ef9eed875ce63e27a5e7f8d80cc:
>
> bpf: make bpf_check_uarg_tail_zero() use check_zeroed_user() (2020-06-01 14:42:37 -0400)
>
> ----------------------------------------------------------------
> Al Viro (9):
> pselect6() and friends: take handling the combined 6th/7th args into helper
> binfmt_elf: don't bother with __{put,copy_to}_user()
> binfmt_elf_fdpic: don't use __... uaccess primitives
This patch breaks arm32:
$ make -sj"$(nproc)" ARCH=arm CROSS_COMPILE=arm-linux-gnueabi- allyesconfig fs/binfmt_elf_fdpic.o
...
In file included from ./include/linux/sched/task.h:11,
from ./include/linux/sched/signal.h:9,
from ./include/linux/rcuwait.h:6,
from ./include/linux/percpu-rwsem.h:7,
from ./include/linux/fs.h:34,
from fs/binfmt_elf_fdpic.c:11:
./include/linux/uaccess.h:149:1: note: declared here
149 | copy_to_user(void __user *to, const void *from, unsigned long n)
| ^~~~~~~~~~~~
fs/binfmt_elf_fdpic.c:612:7: error: too few arguments to function 'copy_to_user'
612 | if (copy_to_user(ent + nr, &v)) \
| ^~~~~~~~~~~~
fs/binfmt_elf_fdpic.c:659:2: note: in expansion of macro 'NEW_AUX_ENT'
659 | NEW_AUX_ENT(AT_EXECFN, bprm->exec);
| ^~~~~~~~~~~
...
Cheers,
Nathan
next prev parent reply other threads:[~2020-06-03 20:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-03 19:23 [git pull] misc uaccess stuff Al Viro
2020-06-03 20:44 ` Nathan Chancellor [this message]
2020-06-03 20:53 ` Al Viro
2020-06-03 21:02 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200603204439.GA2649647@ubuntu-n2-xlarge-x86 \
--to=natechancellor@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).