From: Lee Jones <lee.jones@linaro.org>
To: Luca Ceresoli <luca@lucaceresoli.net>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>, Keerthy <j-keerthy@ti.com>,
Axel Lin <axel.lin@ingics.com>
Subject: Re: [RFC 2/4] regulator: lp87565: dt: remove duplicated section
Date: Thu, 4 Jun 2020 07:48:09 +0100 [thread overview]
Message-ID: <20200604064809.GT3714@dell> (raw)
In-Reply-To: <20200604064734.GS3714@dell>
On Thu, 04 Jun 2020, Lee Jones wrote:
> On Wed, 03 Jun 2020, Luca Ceresoli wrote:
>
> > The "Required properties:" section is copied verbatim for each of the two
> > supported chips. In preparation to add a new chip variant make it a common
> > section and keep the two examples to differentiate between the two chips.
> >
> > Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
> > ---
> > .../devicetree/bindings/mfd/lp87565.txt | 21 ++++---------------
> > 1 file changed, 4 insertions(+), 17 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mfd/lp87565.txt b/Documentation/devicetree/bindings/mfd/lp87565.txt
> > index 41671e0dc26b..b75ae23a1ef3 100644
> > --- a/Documentation/devicetree/bindings/mfd/lp87565.txt
> > +++ b/Documentation/devicetree/bindings/mfd/lp87565.txt
> > @@ -1,7 +1,7 @@
> > TI LP87565 PMIC MFD driver
> >
> > Required properties:
> > - - compatible: "ti,lp87565", "ti,lp87565-q1"
> > + - compatible: one of "ti,lp87565", "ti,lp87565-q1", "ti,lp87561-q1"
>
> What happened to your tabbing here?
>
> All the other entries start with a capital letter. So should this.
This is also an MFD patch. Please change the subject line.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2020-06-04 6:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-03 20:03 [RFC 0/4] regulator: lp87565: ignore ENx pins and add LP87524-Q1 Luca Ceresoli
2020-06-03 20:03 ` [RFC 1/4] regulator: lp87565: enable voltage regardless of ENx pin Luca Ceresoli
2020-06-04 11:07 ` Mark Brown
2020-06-05 7:57 ` Luca Ceresoli
2020-06-03 20:03 ` [RFC 2/4] regulator: lp87565: dt: remove duplicated section Luca Ceresoli
2020-06-04 6:47 ` Lee Jones
2020-06-04 6:48 ` Lee Jones [this message]
2020-06-04 8:44 ` Luca Ceresoli
2020-06-12 22:19 ` Rob Herring
2020-06-14 20:00 ` Luca Ceresoli
2020-06-15 0:54 ` J, KEERTHY
2020-06-03 20:03 ` [RFC 3/4] regulator: lp87565: dt: add LP87524-Q1 variant Luca Ceresoli
2020-06-04 6:01 ` Lee Jones
2020-06-04 8:44 ` Luca Ceresoli
2020-06-03 20:03 ` [RFC 4/4] regulator: lp87565: " Luca Ceresoli
2020-06-04 6:44 ` Lee Jones
2020-06-04 8:52 ` Luca Ceresoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200604064809.GT3714@dell \
--to=lee.jones@linaro.org \
--cc=axel.lin@ingics.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=j-keerthy@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@lucaceresoli.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).