From: Kent Gibson <warthog618@gmail.com>
To: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>
Subject: Re: [RFC PATCH] gpio: uapi: v2 proposal
Date: Thu, 4 Jun 2020 22:23:57 +0800 [thread overview]
Message-ID: <20200604142357.GB5050@sol> (raw)
In-Reply-To: <CAMpxmJVzMJkPSrL4uhfCgjXb7CkLSOH3kW=aeb68LRNJenKRiQ@mail.gmail.com>
On Thu, Jun 04, 2020 at 02:06:31PM +0200, Bartosz Golaszewski wrote:
> śr., 27 maj 2020 o 07:58 Linus Walleij <linus.walleij@linaro.org> napisał(a):
> >
> > On Mon, May 25, 2020 at 4:19 PM Kent Gibson <warthog618@gmail.com> wrote:
> >
> > > > > +struct gpioline_config {
> > > > > + __u8 default_values[GPIOLINES_MAX];
> > > >
> > > > So 32 bytes
> > > >
> > >
> > > Actually that one is 64 bytes, which is the same as v1, i.e. GPIOLINES_MAX
> > > is the same as GPIOHANDLES_MAX - just renamed.
> > >
> > > On the subject of values, is there any reason to use a byte for each line
> > > rather value than a bit?
> >
> > Not really, other than making things simple for userspace.
> >
>
> I'm in favor of using bits here. I think we can rely on libgpiod to
> make things simple for user-space, the kernel interface can be as
> brief as possible.
>
OK, I'll take another look at it. If changed to a bitmap it will have
to be sized as a multiple of 64bits to maintain alignment. Other than
that it should be pretty straight forward.
Cheers,
Kent.
next prev parent reply other threads:[~2020-06-04 14:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-16 6:45 [RFC PATCH] gpio: uapi: v2 proposal Kent Gibson
2020-05-25 8:39 ` Linus Walleij
2020-05-25 14:19 ` Kent Gibson
2020-05-27 5:58 ` Linus Walleij
2020-06-04 12:06 ` Bartosz Golaszewski
2020-06-04 14:23 ` Kent Gibson [this message]
2020-05-25 16:24 ` Bartosz Golaszewski
2020-05-27 0:35 ` Kent Gibson
2020-05-26 8:04 ` Andy Shevchenko
2020-05-26 12:42 ` Kent Gibson
2020-06-04 12:43 ` Bartosz Golaszewski
2020-06-04 16:00 ` Kent Gibson
2020-06-05 9:53 ` Bartosz Golaszewski
2020-06-06 1:56 ` Kent Gibson
2020-06-09 8:03 ` Bartosz Golaszewski
2020-06-09 9:43 ` Kent Gibson
2020-06-09 9:57 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200604142357.GB5050@sol \
--to=warthog618@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).