Re: [PATCH 4.19 00/25] 4.19.128-rc1 review - Greg Kroah-Hartman

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Shuah Khan <skhan@linuxfoundation.org>
Cc: Naresh Kamboju <naresh.kamboju@linaro.org>,
	open list <linux-kernel@vger.kernel.org>,
	Shuah Khan <shuah@kernel.org>,
	patches@kernelci.org, lkft-triage@lists.linaro.org,
	Ben Hutchings <ben.hutchings@codethink.co.uk>,
	linux- stable <stable@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH 4.19 00/25] 4.19.128-rc1 review
Date: Tue, 9 Jun 2020 21:41:22 +0200	[thread overview]
Message-ID: <20200609194122.GA1095933@kroah.com> (raw)
In-Reply-To: <f5429b08-e3d8-f6fb-79bc-3868bf8a2816@linuxfoundation.org>

On Tue, Jun 09, 2020 at 01:20:42PM -0600, Shuah Khan wrote:
> On 6/9/20 1:01 PM, Naresh Kamboju wrote:
> > On Tue, 9 Jun 2020 at 23:21, Greg Kroah-Hartman
> > <gregkh@linuxfoundation.org> wrote:
> > > 
> > > This is the start of the stable review cycle for the 4.19.128 release.
> > > There are 25 patches in this series, all will be posted as a response
> > > to this one.  If anyone has any issues with these being applied, please
> > > let me know.
> > > 
> > > Responses should be made by Thu, 11 Jun 2020 17:40:24 +0000.
> > > Anything received after that time might be too late.
> > > 
> > > The whole patch series can be found in one patch at:
> > >          https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.128-rc1.gz
> > > or in the git tree and branch at:
> > >          git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> > > and the diffstat can be found below.
> > > 
> > > thanks,
> > > 
> > > greg k-h
> > > 
> > > -------------
> > > Pseudo-Shortlog of commits:
> > > 
> > > Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > >      Linux 4.19.128-rc1
> > > 
> > > Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > >      Revert "net/mlx5: Annotate mutex destroy for root ns"
> > > 
> > > Oleg Nesterov <oleg@redhat.com>
> > >      uprobes: ensure that uprobe->offset and ->ref_ctr_offset are properly aligned
> > 
> > stable-rc 4.19 build failure for x86_64, i386 and arm.
> > 
> >   make -sk KBUILD_BUILD_USER=TuxBuild -C/linux -j16 ARCH=x86 HOSTCC=gcc
> > CC="sccache gcc" O=build
> > 75 #
> > 76 In file included from ../kernel/events/uprobes.c:25:
> > 77 ../kernel/events/uprobes.c: In function ‘__uprobe_register’:
> > 78 ../kernel/events/uprobes.c:916:18: error: ‘ref_ctr_offset’
> > undeclared (first use in this function); did you mean
> > ‘per_cpu_offset’?
> > 79  916 | if (!IS_ALIGNED(ref_ctr_offset, sizeof(short)))
> > 80  | ^~~~~~~~~~~~~~
> > 81 ../include/linux/kernel.h:62:30: note: in definition of macro ‘IS_ALIGNED’
> > 82  62 | #define IS_ALIGNED(x, a) (((x) & ((typeof(x))(a) - 1)) == 0)
> > 83  | ^
> > 84 ../kernel/events/uprobes.c:916:18: note: each undeclared identifier
> > is reported only once for each function it appears in
> > 85  916 | if (!IS_ALIGNED(ref_ctr_offset, sizeof(short)))
> > 86  | ^~~~~~~~~~~~~~
> > 87 ../include/linux/kernel.h:62:30: note: in definition of macro ‘IS_ALIGNED’
> > 88  62 | #define IS_ALIGNED(x, a) (((x) & ((typeof(x))(a) - 1)) == 0)
> > 89  | ^
> > 90 make[3]: *** [../scripts/Makefile.build:304: kernel/events/uprobes.o] Error 1
> > 
> > kernel config:
> > https://builds.tuxbuild.com/I3PT6_HS4PTt7EFgJUIPxA/kernel.config
> > 
> 
> I am seeing the same problem on x86_64
> 
> CONFIG_UPROBES is enabled in my config.

Should be fixed in the -rc2 release, sorry about that.

greg k-h