Re: [PATCH v4 2/5] dt-bindings: regulator: Add labibb regulator

[Rob Herring <robh@kernel.org>]

On Tue, Jun 02, 2020 at 03:39:21PM +0530, Sumit Semwal wrote:
> From: Nisha Kumari <nishakumari@codeaurora.org>
> 
> Adding the devicetree binding for labibb regulator.
> 
> Signed-off-by: Nisha Kumari <nishakumari@codeaurora.org>
> Signed-off-by: Sumit Semwal <sumit.semwal@linaro.org>
>  [sumits: cleanup as per review comments and update to yaml]
> --
> v2: updated for better compatible string and names.
> v3: moved to yaml
> v4: fixed dt_binding_check issues
> ---
>  .../regulator/qcom-labibb-regulator.yaml      | 79 +++++++++++++++++++
>  1 file changed, 79 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml
> 
> diff --git a/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml
> new file mode 100644
> index 000000000000..178820ec04c7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml
> @@ -0,0 +1,79 @@
> +# SPDX-License-Identifier: GPL-2.0-only

Dual license new bindings:

(GPL-2.0-only OR BSD-2-Clause)

> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/regulator/qcom-labibb-regulator.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm's LAB(LCD AMOLED Boost)/IBB(Inverting Buck Boost) Regulator
> +
> +maintainers:
> +  - Sumit Semwal <sumit.semwal@linaro.org>
> +
> +description:
> +  LAB can be used as a positive boost power supply and IBB can be used as a
> +  negative boost power supply for display panels. Currently implemented for
> +  pmi8998.
> +
> +allOf:
> +  - $ref: "regulator.yaml#"

I think you want this under each child as this schema applies to each 
regulator. But you aren't using any of the regulator properties, so not 
even needed? Or the example is not complete?

> +
> +properties:
> +  compatible:
> +    const: qcom,pmi8998-lab-ibb
> +
> +  lab:
> +    type: object
> +
> +    properties:
> +
> +      interrupts:
> +        maxItems: 1
> +        description:
> +          Short-circuit interrupt for lab.
> +
> +      interrupt-names:
> +        const: sc-err

You don't really need a name if there's only 1.

> +
> +    required:
> +    - interrupts
> +    - interrupt-names
> +
> +  ibb:
> +    type: object
> +
> +    properties:
> +
> +      interrupts:
> +        maxItems: 1
> +        description:
> +          Short-circuit interrupt for lab.
> +
> +      interrupt-names:
> +        const: sc-err
> +
> +    required:
> +    - interrupts
> +    - interrupt-names
> +
> +required:
> +  - compatible

unevaluatedProperties: false

> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +
> +    labibb {
> +      compatible = "qcom,pmi8998-lab-ibb";
> +
> +      lab {
> +        interrupts = <0x3 0x0 IRQ_TYPE_EDGE_RISING>;
> +        interrupt-names = "sc-err";
> +      };
> +
> +      ibb {
> +        interrupts = <0x3 0x2 IRQ_TYPE_EDGE_RISING>;
> +        interrupt-names = "sc-err";
> +      };
> +    };
> +
> +...
> -- 
> 2.26.2
>