From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Prarit Bhargava <prarit@redhat.com>
Cc: linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Tony Luck <tony.luck@intel.com>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Rahul Tanwar <rahul.tanwar@linux.intel.com>,
Xiaoyao Li <xiaoyao.li@intel.com>,
Ricardo Neri <ricardo.neri-calderon@linux.intel.com>,
Dave Hansen <dave.hansen@linux.intel.com>
Subject: Re: [PATCH v3] x86/split_lock: Sanitize userspace and guest error output
Date: Mon, 15 Jun 2020 18:51:31 -0700 [thread overview]
Message-ID: <20200616015131.GA26491@linux.intel.com> (raw)
In-Reply-To: <20200615113900.35697-1-prarit@redhat.com>
On Mon, Jun 15, 2020 at 07:39:00AM -0400, Prarit Bhargava wrote:
> There are two problems with kernel messages in fatal mode that were found
> during testing of guests and userspace programs.
>
> The first is that no kernel message is output when the split lock detector
> is triggered with a userspace program. As a result the userspace process
> dies from receiving SIGBUS with no indication to the user of what caused
> the process to die.
>
> The second problem is that only the first triggering guest causes a kernel
> message to be output because the message is output with pr_warn_once().
> This also results in a loss of information to the user.
>
> While fixing these I noticed that the same message was being output
> three times so I'm cleaning that up too.
>
> Fix fatal mode output, and use consistent messages for fatal and
> warn modes for both userspace and guests.
>
> Signed-off-by: Prarit Bhargava <prarit@redhat.com>
> Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
This needs a Co-developed-by for me, and your SOB should come last, e.g.
Co-developed-by: Sean Christopherson <sean.j.christopherson@intel.com>
Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
Signed-off-by: Prarit Bhargava <prarit@redhat.com>
See "12) When to use Acked-by:, Cc:, and Co-developed-by:" in
Documentation/process/submitting-patches.rst for more details.
prev parent reply other threads:[~2020-06-16 1:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-15 11:39 [PATCH v3] x86/split_lock: Sanitize userspace and guest error output Prarit Bhargava
2020-06-16 1:51 ` Sean Christopherson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200616015131.GA26491@linux.intel.com \
--to=sean.j.christopherson@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=prarit@redhat.com \
--cc=rahul.tanwar@linux.intel.com \
--cc=ricardo.neri-calderon@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=xiaoyao.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).