From: kernel test robot <lkp@intel.com>
To: Syed Nayyar Waris <syednwaris@gmail.com>,
linus.walleij@linaro.org, akpm@linux-foundation.org
Cc: kbuild-all@lists.01.org, andriy.shevchenko@linux.intel.com,
vilhelm.gray@gmail.com, bgolaszewski@baylibre.com,
michal.simek@xilinx.com, linux-gpio@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 4/4] gpio: xilinx: Utilize for_each_set_clump macro
Date: Tue, 16 Jun 2020 04:09:23 +0800 [thread overview]
Message-ID: <202006160420.iatdr9ab%lkp@intel.com> (raw)
In-Reply-To: <46c05c5deeada60a13ee0de83c68583d578f42fd.1592224129.git.syednwaris@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 4203 bytes --]
Hi Syed,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on 444fc5cde64330661bf59944c43844e7d4c2ccd8]
url: https://github.com/0day-ci/linux/commits/Syed-Nayyar-Waris/Introduce-the-for_each_set_clump-macro/20200615-205729
base: 444fc5cde64330661bf59944c43844e7d4c2ccd8
config: sparc64-randconfig-s032-20200615 (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.2-rc1-3-g55607964-dirty
# save the attached .config to linux build tree
make W=1 C=1 ARCH=sparc64 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> include/linux/bitmap.h:639:45: sparse: sparse: shift too big (64) for type unsigned long
>> include/linux/bitmap.h:639:45: sparse: sparse: shift too big (64) for type unsigned long
include/linux/bitmap.h:594:63: sparse: sparse: shift too big (64) for type unsigned long
>> include/linux/bitmap.h:639:45: sparse: sparse: shift too big (64) for type unsigned long
>> include/linux/bitmap.h:638:17: sparse: sparse: invalid access past the end of 'old' (8 8)
vim +639 include/linux/bitmap.h
169c474fb22d8a William Breathitt Gray 2019-12-04 613
803024b6c8a375 Syed Nayyar Waris 2020-06-15 614 /**
803024b6c8a375 Syed Nayyar Waris 2020-06-15 615 * bitmap_set_value - set n-bit value within a memory region
803024b6c8a375 Syed Nayyar Waris 2020-06-15 616 * @map: address to the bitmap memory region
803024b6c8a375 Syed Nayyar Waris 2020-06-15 617 * @value: value of nbits
803024b6c8a375 Syed Nayyar Waris 2020-06-15 618 * @start: bit offset of the n-bit value
803024b6c8a375 Syed Nayyar Waris 2020-06-15 619 * @nbits: size of value in bits
803024b6c8a375 Syed Nayyar Waris 2020-06-15 620 */
803024b6c8a375 Syed Nayyar Waris 2020-06-15 621 static inline void bitmap_set_value(unsigned long *map,
803024b6c8a375 Syed Nayyar Waris 2020-06-15 622 unsigned long value,
803024b6c8a375 Syed Nayyar Waris 2020-06-15 623 unsigned long start, unsigned long nbits)
803024b6c8a375 Syed Nayyar Waris 2020-06-15 624 {
803024b6c8a375 Syed Nayyar Waris 2020-06-15 625 const size_t index = BIT_WORD(start);
803024b6c8a375 Syed Nayyar Waris 2020-06-15 626 const unsigned long offset = start % BITS_PER_LONG;
803024b6c8a375 Syed Nayyar Waris 2020-06-15 627 const unsigned long ceiling = roundup(start + 1, BITS_PER_LONG);
803024b6c8a375 Syed Nayyar Waris 2020-06-15 628 const unsigned long space = ceiling - start;
803024b6c8a375 Syed Nayyar Waris 2020-06-15 629
803024b6c8a375 Syed Nayyar Waris 2020-06-15 630 value &= GENMASK(nbits - 1, 0);
803024b6c8a375 Syed Nayyar Waris 2020-06-15 631
803024b6c8a375 Syed Nayyar Waris 2020-06-15 632 if (space >= nbits) {
803024b6c8a375 Syed Nayyar Waris 2020-06-15 633 map[index] &= ~(GENMASK(nbits + offset - 1, offset));
803024b6c8a375 Syed Nayyar Waris 2020-06-15 634 map[index] |= value << offset;
803024b6c8a375 Syed Nayyar Waris 2020-06-15 635 } else {
803024b6c8a375 Syed Nayyar Waris 2020-06-15 636 map[index] &= ~BITMAP_FIRST_WORD_MASK(start);
803024b6c8a375 Syed Nayyar Waris 2020-06-15 637 map[index] |= value << offset;
803024b6c8a375 Syed Nayyar Waris 2020-06-15 @638 map[index + 1] &= ~BITMAP_LAST_WORD_MASK(start + nbits);
803024b6c8a375 Syed Nayyar Waris 2020-06-15 @639 map[index + 1] |= (value >> space);
803024b6c8a375 Syed Nayyar Waris 2020-06-15 640 }
803024b6c8a375 Syed Nayyar Waris 2020-06-15 641 }
803024b6c8a375 Syed Nayyar Waris 2020-06-15 642
:::::: The code at line 639 was first introduced by commit
:::::: 803024b6c8a375ba9e9e9467595d7d52d4f6a38e bitops: Introduce the for_each_set_clump macro
:::::: TO: Syed Nayyar Waris <syednwaris@gmail.com>
:::::: CC: 0day robot <lkp@intel.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 26635 bytes --]
next prev parent reply other threads:[~2020-06-15 20:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-15 12:50 [PATCH v8 0/4] Introduce the for_each_set_clump macro Syed Nayyar Waris
2020-06-15 12:51 ` [PATCH v8 1/4] bitops: " Syed Nayyar Waris
2020-06-15 13:56 ` Andy Shevchenko
2020-06-15 16:47 ` kernel test robot
2020-06-16 8:14 ` Andy Shevchenko
2020-06-20 13:45 ` Syed Nayyar Waris
2020-06-20 23:41 ` Syed Nayyar Waris
2020-06-17 8:00 ` kernel test robot
2020-06-15 12:52 ` [PATCH v8 2/4] lib/test_bitmap.c: Add for_each_set_clump test cases Syed Nayyar Waris
2020-06-15 12:53 ` [PATCH v8 3/4] gpio: thunderx: Utilize for_each_set_clump macro Syed Nayyar Waris
2020-06-15 12:54 ` [PATCH v8 4/4] gpio: xilinx: " Syed Nayyar Waris
2020-06-15 20:09 ` kernel test robot [this message]
2020-06-16 5:57 ` Syed Nayyar Waris
2020-06-19 14:26 ` Luc Van Oostenryck
2020-06-19 7:00 ` Syed Nayyar Waris
2020-06-19 8:38 ` Andy Shevchenko
2020-06-19 9:05 ` Andy Shevchenko
2020-06-19 19:17 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202006160420.iatdr9ab%lkp@intel.com \
--to=lkp@intel.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=kbuild-all@lists.01.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=syednwaris@gmail.com \
--cc=vilhelm.gray@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).