linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Hemant Kumar <hemantk@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	jhugo@codeaurora.org, bbhatt@codeaurora.org
Subject: Re: [PATCH v3 2/4] bus: mhi: core: Move MHI_MAX_MTU to external header file
Date: Fri, 19 Jun 2020 11:03:53 +0530	[thread overview]
Message-ID: <20200619053353.GB3245@Mani-XPS-13-9360> (raw)
In-Reply-To: <1591899224-3403-3-git-send-email-hemantk@codeaurora.org>

On Thu, Jun 11, 2020 at 11:13:42AM -0700, Hemant Kumar wrote:
> Currently this macro is defined in internal MHI header as
> a TRE length mask. Moving it to external header allows MHI
> client drivers to set this upper bound for the transmit
> buffer size.
> 

So we have 2 definitions for MHI_MAX_MTU now? Why can't you remove the one
available internally?

Thanks,
Mani

> Signed-off-by: Hemant Kumar <hemantk@codeaurora.org>
> ---
>  include/linux/mhi.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/include/linux/mhi.h b/include/linux/mhi.h
> index a39b77d..ce43f74 100644
> --- a/include/linux/mhi.h
> +++ b/include/linux/mhi.h
> @@ -16,6 +16,9 @@
>  #include <linux/wait.h>
>  #include <linux/workqueue.h>
>  
> +/* MHI client drivers to set this upper bound for tx buffer */
> +#define MHI_MAX_MTU 0xffff
> +
>  #define MHI_VOTE_BUS BIT(0) /* do not disable the mhi bus */
>  #define MHI_VOTE_DEVICE BIT(1) /* prevent mhi device from entering lpm */
>  
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
> 

  reply	other threads:[~2020-06-19  5:34 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-11 18:13 [PATCH v3 0/4] user space client interface driver Hemant Kumar
2020-06-11 18:13 ` [PATCH v3 1/4] bus: mhi: core: Add helper API to return number of free TREs Hemant Kumar
2020-06-19  5:31   ` Manivannan Sadhasivam
2020-06-11 18:13 ` [PATCH v3 2/4] bus: mhi: core: Move MHI_MAX_MTU to external header file Hemant Kumar
2020-06-19  5:33   ` Manivannan Sadhasivam [this message]
2020-06-25  0:03     ` Hemant Kumar
2020-06-11 18:13 ` [PATCH v3 3/4] docs: Add documentation for user space client interface Hemant Kumar
2020-06-19  6:39   ` Manivannan Sadhasivam
2020-06-25  1:52     ` Hemant Kumar
2020-06-25  6:23       ` Manivannan Sadhasivam
2020-06-25  6:27         ` Manivannan Sadhasivam
2020-06-11 18:13 ` [PATCH v3 4/4] bus: mhi: clients: Add user space client interface driver Hemant Kumar
2020-06-19 10:40   ` Manivannan Sadhasivam
2020-07-21  3:40     ` Hemant Kumar
2020-07-22  8:45       ` Manivannan Sadhasivam
2020-07-24 23:47         ` Hemant Kumar
2020-07-25 16:49           ` Manivannan Sadhasivam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200619053353.GB3245@Mani-XPS-13-9360 \
    --to=manivannan.sadhasivam@linaro.org \
    --cc=bbhatt@codeaurora.org \
    --cc=hemantk@codeaurora.org \
    --cc=jhugo@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).