From: Sebastian Reichel <sre@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Laurentiu Palcu <laurentiu.palcu@intel.com>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: power: supply: bq25890: Document required interrupt
Date: Fri, 19 Jun 2020 16:39:06 +0200 [thread overview]
Message-ID: <20200619143906.33twapu6mgyay4yr@earth.universe> (raw)
In-Reply-To: <20200617102305.14241-2-krzk@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1550 bytes --]
Hi,
On Wed, Jun 17, 2020 at 12:23:05PM +0200, Krzysztof Kozlowski wrote:
> The driver requires interrupts (fails probe if it is not provided) so
> document this requirement in bindings.
>
> Fixes: 4aeae9cb0dad ("power_supply: Add support for TI BQ25890 charger chip")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
Thanks, queued.
-- Sebastian
> Documentation/devicetree/bindings/power/supply/bq25890.txt | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/power/supply/bq25890.txt b/Documentation/devicetree/bindings/power/supply/bq25890.txt
> index 51ecc756521f..3b4c69a7fa70 100644
> --- a/Documentation/devicetree/bindings/power/supply/bq25890.txt
> +++ b/Documentation/devicetree/bindings/power/supply/bq25890.txt
> @@ -10,6 +10,7 @@ Required properties:
> * "ti,bq25895"
> * "ti,bq25896"
> - reg: integer, i2c address of the device.
> +- interrupts: interrupt line;
> - ti,battery-regulation-voltage: integer, maximum charging voltage (in uV);
> - ti,charge-current: integer, maximum charging current (in uA);
> - ti,termination-current: integer, charge will be terminated when current in
> @@ -39,6 +40,9 @@ bq25890 {
> compatible = "ti,bq25890";
> reg = <0x6a>;
>
> + interrupt-parent = <&gpio1>;
> + interrupts = <16 IRQ_TYPE_EDGE_FALLING>;
> +
> ti,battery-regulation-voltage = <4200000>;
> ti,charge-current = <1000000>;
> ti,termination-current = <50000>;
> --
> 2.17.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-06-19 16:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 10:23 [PATCH 1/2] dt-bindings: power: supply: bq25890: Indent example with tabs Krzysztof Kozlowski
2020-06-17 10:23 ` [PATCH 2/2] dt-bindings: power: supply: bq25890: Document required interrupt Krzysztof Kozlowski
2020-06-19 14:39 ` Sebastian Reichel [this message]
2020-06-19 14:38 ` [PATCH 1/2] dt-bindings: power: supply: bq25890: Indent example with tabs Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200619143906.33twapu6mgyay4yr@earth.universe \
--to=sre@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=laurentiu.palcu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).