From: Mike Rapoport <rppt@kernel.org>
To: David Rientjes <rientjes@google.com>
Cc: Su Hui <sh_def@163.com>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH] mm: remove the redundancy code
Date: Mon, 29 Jun 2020 23:24:29 +0300 [thread overview]
Message-ID: <20200629202429.GG1492837@kernel.org> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2006291149040.1030250@chino.kir.corp.google.com>
On Mon, Jun 29, 2020 at 11:50:15AM -0700, David Rientjes wrote:
> On Tue, 30 Jun 2020, Su Hui wrote:
>
> > remove the redundancy code, the zone_start_pfn
> > is assigned from zone->zone_start_pfn
> > Signed-off-by: Su Hui <sh_def@163.com>
>
> I don't think this is redundant, it's used by memory hotplug when onlining
> new memory.
Right, it is:
$ git grep -wn init_currently_empty_zone mm/memory_hotplug.c
mm/memory_hotplug.c:697: init_currently_empty_zone(zone, start_pfn, nr_pages);
> > ---
> > mm/page_alloc.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> > index 3c4eb750a199..3372a8c9fbc4 100644
> > --- a/mm/page_alloc.c
> > +++ b/mm/page_alloc.c
> > @@ -6215,8 +6215,6 @@ void __meminit init_currently_empty_zone(struct zone *zone,
> > if (zone_idx > pgdat->nr_zones)
> > pgdat->nr_zones = zone_idx;
> >
> > - zone->zone_start_pfn = zone_start_pfn;
> > -
> > mminit_dprintk(MMINIT_TRACE, "memmap_init",
> > "Initialising map node %d zone %lu pfns %lu -> %lu\n",
> > pgdat->node_id,
>
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2020-06-29 20:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 17:30 [PATCH] mm: remove the redundancy code Su Hui
2020-06-29 18:50 ` David Rientjes
2020-06-29 20:24 ` Mike Rapoport [this message]
[not found] ` <3f4b9136.1440.17302f60674.Coremail.sh_def@163.com>
2020-06-30 2:06 ` David Rientjes
2020-06-30 2:37 ` 苏辉
2020-06-30 10:28 ` kernel test robot
2020-06-30 11:52 ` kernel test robot
2020-06-30 12:39 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200629202429.GG1492837@kernel.org \
--to=rppt@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=sh_def@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).