From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ran Wang <ran.wang_1@nxp.com>
Cc: Peter Chen <peter.chen@nxp.com>,
"balbi@kernel.org" <balbi@kernel.org>,
Leo Li <leoyang.li@nxp.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] USB: phy: fsl-usb: remove character device usage
Date: Fri, 3 Jul 2020 09:02:21 +0200 [thread overview]
Message-ID: <20200703070221.GA2221524@kroah.com> (raw)
In-Reply-To: <AM6PR04MB54133D6402EE1FDC7E44CB32F16A0@AM6PR04MB5413.eurprd04.prod.outlook.com>
On Fri, Jul 03, 2020 at 01:56:28AM +0000, Ran Wang wrote:
> Hi
>
> On Thursday, July 2, 2020 5:08 PM, Peter Chen wrote
> > >
> > > No idea why this driver is using a char device node, statically
> > > allocated, with no dynamic allocation or hook up with devtmpfs, along
> > > with a reserverd major number, for "special" operations, not all of which ever
> > were implemented.
> > >
> > > So just rip it out, as no one must be using it because no modern
> > > system will ever actually create the /dev/ node it needs.
> > >
> >
> > Add related people from NXP.
> >
>
> Reviewed-by: Ran Wang <ran.wang_1@nxp.com>
Thanks for the review!
greg k-h
next prev parent reply other threads:[~2020-07-03 7:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 7:29 [PATCH 1/2] USB: phy: fsl-usb: remove sysfs abuse Greg Kroah-Hartman
2020-07-02 7:29 ` [PATCH 2/2] USB: phy: fsl-usb: remove character device usage Greg Kroah-Hartman
2020-07-02 9:07 ` Peter Chen
2020-07-02 10:33 ` Greg Kroah-Hartman
2020-07-03 1:56 ` Ran Wang
2020-07-03 7:02 ` Greg Kroah-Hartman [this message]
2020-07-02 9:07 ` [PATCH 1/2] USB: phy: fsl-usb: remove sysfs abuse Peter Chen
2020-07-03 1:49 ` Ran Wang
2020-07-23 11:40 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200703070221.GA2221524@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=balbi@kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.chen@nxp.com \
--cc=ran.wang_1@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).