From: Maxime Ripard <maxime@cerno.tech>
To: "Clément Péron" <peron.clem@gmail.com>
Cc: Rob Herring <robh@kernel.org>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>,
Steven Price <steven.price@arm.com>,
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>,
Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
Stephen Boyd <sboyd@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 13/14] [DO NOT MERGE] arm64: dts: allwinner: h6: Add GPU OPP table
Date: Sat, 4 Jul 2020 14:13:01 +0200 [thread overview]
Message-ID: <20200704121301.jfd3m3jnlghmddg4@gilmour.lan> (raw)
In-Reply-To: <20200704102535.189647-14-peron.clem@gmail.com>
Hi,
On Sat, Jul 04, 2020 at 12:25:34PM +0200, Clément Péron wrote:
> Add an Operating Performance Points table for the GPU to
> enable Dynamic Voltage & Frequency Scaling on the H6.
>
> The voltage range is set with minival voltage set to the target
> and the maximal voltage set to 1.2V. This allow DVFS framework to
> work properly on board with fixed regulator.
>
> Signed-off-by: Clément Péron <peron.clem@gmail.com>
That patch seems reasonable, why shouldn't we merge it?
> ---
> arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 80 ++++++++++++++++++++
> 1 file changed, 80 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
> index 8f514a2169aa..a69f9e09a829 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
> @@ -174,6 +174,7 @@ gpu: gpu@1800000 {
> clocks = <&ccu CLK_GPU>, <&ccu CLK_BUS_GPU>;
> clock-names = "core", "bus";
> resets = <&ccu RST_BUS_GPU>;
> + operating-points-v2 = <&gpu_opp_table>;
> #cooling-cells = <2>;
> status = "disabled";
> };
> @@ -1036,4 +1037,83 @@ map0 {
> };
> };
> };
> +
> + gpu_opp_table: gpu-opp-table {
> + compatible = "operating-points-v2";
> +
> + opp@216000000 {
> + opp-hz = /bits/ 64 <216000000>;
> + opp-microvolt = <810000 810000 1200000>;
> + };
All those nodes will create DTC warnings though.
Maxime
next prev parent reply other threads:[~2020-07-04 12:13 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-04 10:25 [PATCH v2 00/14] Add regulator devfreq support to Panfrost Clément Péron
2020-07-04 10:25 ` [PATCH v2 01/14] drm/panfrost: avoid static declaration Clément Péron
2020-07-04 10:25 ` [PATCH v2 02/14] drm/panfrost: clean headers in devfreq Clément Péron
2020-07-04 10:25 ` [PATCH v2 03/14] drm/panfrost: don't use pfdevfreq.busy_count to know if hw is idle Clément Péron
2020-07-04 10:25 ` [PATCH v2 04/14] drm/panfrost: introduce panfrost_devfreq struct Clément Péron
2020-07-04 10:25 ` [PATCH v2 05/14] drm/panfrost: use spinlock instead of atomic Clément Péron
2020-07-04 10:25 ` [PATCH v2 06/14] drm/panfrost: properly handle error in probe Clément Péron
2020-07-04 10:25 ` [PATCH v2 07/14] drm/panfrost: rename error labels in device_init Clément Péron
2020-07-04 10:25 ` [PATCH v2 08/14] drm/panfrost: move devfreq_init()/fini() in device Clément Péron
2020-07-04 10:25 ` [PATCH v2 09/14] drm/panfrost: dynamically alloc regulators Clément Péron
2020-07-04 10:25 ` [PATCH v2 10/14] drm/panfrost: add regulators to devfreq Clément Péron
2020-07-04 10:25 ` [PATCH v2 11/14] arm64: defconfig: Enable devfreq cooling device Clément Péron
2020-07-04 10:25 ` [PATCH v2 12/14] arm64: dts: allwinner: h6: Add cooling map for GPU Clément Péron
2020-07-04 10:25 ` [PATCH v2 13/14] [DO NOT MERGE] arm64: dts: allwinner: h6: Add GPU OPP table Clément Péron
2020-07-04 12:13 ` Maxime Ripard [this message]
2020-07-04 14:56 ` Clément Péron
2020-08-03 7:54 ` Clément Péron
2020-08-24 13:11 ` Maxime Ripard
2020-08-28 12:16 ` Clément Péron
2020-08-28 12:21 ` Ondřej Jirman
2020-08-28 13:01 ` [linux-sunxi] " Jernej Škrabec
2020-07-04 10:25 ` [PATCH v2 14/14] [DO NOT MERGE] arm64: dts: allwinner: force GPU regulator to be always Clément Péron
2020-07-04 10:30 ` Clément Péron
2020-07-04 10:28 ` [PATCH v2 00/14] Add regulator devfreq support to Panfrost Clément Péron
2020-07-06 13:26 ` Alyssa Rosenzweig
2020-07-07 0:16 ` Ondřej Jirman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200704121301.jfd3m3jnlghmddg4@gilmour.lan \
--to=maxime@cerno.tech \
--cc=alyssa.rosenzweig@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=peron.clem@gmail.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=steven.price@arm.com \
--cc=tomeu.vizoso@collabora.com \
--cc=vireshk@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).