From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99DACC433E0 for ; Mon, 6 Jul 2020 06:34:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 848B020739 for ; Mon, 6 Jul 2020 06:34:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728029AbgGFGem (ORCPT ); Mon, 6 Jul 2020 02:34:42 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:56429 "EHLO relay6-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727039AbgGFGem (ORCPT ); Mon, 6 Jul 2020 02:34:42 -0400 X-Originating-IP: 90.65.108.121 Received: from localhost (lfbn-lyo-1-1676-121.w90-65.abo.wanadoo.fr [90.65.108.121]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id DD885C000B; Mon, 6 Jul 2020 06:34:38 +0000 (UTC) Date: Mon, 6 Jul 2020 08:34:38 +0200 From: Alexandre Belloni To: Johnson CH Chen =?utf-8?B?KOmZs+aYreWLsyk=?= Cc: Guenter Roeck , "linux-kernel@vger.kernel.org" , "linux-rtc@vger.kernel.org" , "linux-watchdog@vger.kernel.org" , Wim Van Sebroeck , Alessandro Zummo Subject: Re: [PATCH v2] rtc: rtc-ds1374: wdt: Use watchdog core for watchdog part Message-ID: <20200706063438.GF6538@piout.net> References: <20200705152410.GB5663@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/07/2020 05:18:39+0000, Johnson CH Chen (陳昭勳) wrote: > > > #endif /*CONFIG_RTC_DRV_DS1374_WDT*/ > > > /* > > > @@ -653,15 +514,25 @@ static int ds1374_probe(struct i2c_client > > > *client, > > > > > > #ifdef CONFIG_RTC_DRV_DS1374_WDT > > > save_client = client; > > > - ret = misc_register(&ds1374_miscdev); > > > - if (ret) > > > - return ret; > > > - ret = register_reboot_notifier(&ds1374_wdt_notifier); > > > + ds1374->wdt.info = &ds1374_wdt_info; > > > + ds1374->wdt.ops = &ds1374_wdt_ops; > > > + ds1374->wdt.timeout = TIMER_MARGIN_DEFAULT; > > > + ds1374->wdt.min_timeout = TIMER_MARGIN_MIN; > > > + ds1374->wdt.max_timeout = TIMER_MARGIN_MAX; > > > + > > > + watchdog_init_timeout(&ds1374->wdt, wdt_margin, &client->dev); > > > + watchdog_set_nowayout(&ds1374->wdt, nowayout); > > > + watchdog_stop_on_reboot(&ds1374->wdt); > > > + watchdog_stop_on_unregister(&ds1374->wdt); > > > + ds1374_wdt_settimeout(&ds1374->wdt, wdt_margin); > > > + > > > + ret = devm_watchdog_register_device(&client->dev, &ds1374->wdt); > > > if (ret) { > > > - misc_deregister(&ds1374_miscdev); > > > + dev_err(&client->dev, "failed to register DS1374 watchdog > > > +device\n"); There was no error message before, I don't think this one is necessary. > > > return ret; > > > } > > > - ds1374_wdt_settimeout(131072); > > > + > > > + dev_info(&client->dev, "DS1374 watchdog device enabled\n"); > > > > Is that necessary ? > > > > I think it's good to show watchdog initial timeout. I'll include above suggestions in v3, thanks! > No, please avoid adding more strings in that driver. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com