From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70CF0C433E0 for ; Tue, 7 Jul 2020 23:59:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4E6E12073B for ; Tue, 7 Jul 2020 23:59:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="LafhCb4t" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729446AbgGGX7m (ORCPT ); Tue, 7 Jul 2020 19:59:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56434 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728673AbgGGX7l (ORCPT ); Tue, 7 Jul 2020 19:59:41 -0400 Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6578DC061755 for ; Tue, 7 Jul 2020 16:59:41 -0700 (PDT) Received: by mail-pg1-x541.google.com with SMTP id e8so20780973pgc.5 for ; Tue, 07 Jul 2020 16:59:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=t+MUHlMV05Venpi+dxgNFy9m2mM7Us7wpJwUgu+0RIA=; b=LafhCb4tq/+15NiiNOG2BKxCpeSoxaozRMft+310cV24Ytgchd8f5pyzQOSHeWZXfw sY1Dm+QXQug+61+HPKC9CsVVEyxHf9zqWNxuuTHnNPhg66oQiL6GpDh7ADEmoCmMSf41 2+4zCqnrVxslrHZBmUrwZXf+GBK3TOSDNm1TQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=t+MUHlMV05Venpi+dxgNFy9m2mM7Us7wpJwUgu+0RIA=; b=NkYXtsq92mukwaoL/hAxF4+0B7dvJEIHkGe9p2DceJ5jhLvAD7S1ii80wOkMA0F8xk 9oBu/OcxKC6LAcF2w0sWE9ukL6yni8t8+bPWOhNSyHx8Q/VV8Bc5Wwf36UNGfTGlaZfj 5cicjiOvmgzNabeegVY5ccwTC/Ymz1OCsC5dLJ3CZdvWHpRwPH3uB/wNjDOJA2bcFk0y OnOeHaaSfZjhgBzeU8+ytqjuDJ80IIHjBAV+Eky8M+jz4+z5jyhhinVGJaId1ESCXo6h 8/+vMVYopY/r5/CZG7ju7pPKmNIg9jLYP1Vg492ycK00SX9QjAiZouKacmuZn2G/xFYd sQeQ== X-Gm-Message-State: AOAM530taVAJDqV8RmILg17xCU1A20gBTBuD17vEO7jTqZ4h97MyOgzO mGkCfuDAmCC/nlfxIEenML2lVQ== X-Google-Smtp-Source: ABdhPJxrg7MIOsckToNcEU8cl8R/PG88U4PcKuHFAM793HgSei/rQl//+UCXuWhNnVDpB4swbIRxQw== X-Received: by 2002:aa7:8651:: with SMTP id a17mr44429243pfo.48.1594166381010; Tue, 07 Jul 2020 16:59:41 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id 66sm10992837pfg.63.2020.07.07.16.59.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 16:59:40 -0700 (PDT) Date: Tue, 7 Jul 2020 16:59:39 -0700 From: Kees Cook To: Scott Branden Cc: Luis Chamberlain , Wolfram Sang , Greg Kroah-Hartman , David Brown , Alexander Viro , Shuah Khan , bjorn.andersson@linaro.org, Shuah Khan , Arnd Bergmann , Mimi Zohar , "Rafael J . Wysocki" , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-fsdevel@vger.kernel.org, BCM Kernel Feedback , Olof Johansson , Andrew Morton , Dan Carpenter , Colin Ian King , Takashi Iwai , linux-kselftest@vger.kernel.org, Andy Gross , linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org Subject: Re: [PATCH v10 4/9] test_firmware: add partial read support for request_firmware_into_buf Message-ID: <202007071659.38721F7@keescook> References: <20200706232309.12010-1-scott.branden@broadcom.com> <20200706232309.12010-5-scott.branden@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200706232309.12010-5-scott.branden@broadcom.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 06, 2020 at 04:23:04PM -0700, Scott Branden wrote: > Add additional hooks to test_firmware to pass in support > for partial file read using request_firmware_into_buf. > buf_size: size of buffer to request firmware into > partial: indicates that a partial file request is being made > file_offset: to indicate offset into file to request > > Signed-off-by: Scott Branden I am a fan of tests. :) If Luis gives an Ack here, you're good. -- Kees Cook