From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8F1AC433E1 for ; Tue, 7 Jul 2020 18:48:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C8CFA206E2 for ; Tue, 7 Jul 2020 18:48:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="m57SDtNZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728487AbgGGSsL (ORCPT ); Tue, 7 Jul 2020 14:48:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36468 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728225AbgGGSsK (ORCPT ); Tue, 7 Jul 2020 14:48:10 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79666C08C5E1 for ; Tue, 7 Jul 2020 11:48:10 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id z15so35053396wrl.8 for ; Tue, 07 Jul 2020 11:48:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=sz1Hi8LN71IdWVES3Rm3QlYRfh+YKsdF8gF0JiM3gaE=; b=m57SDtNZKCtFUfyMe3NixudgPZws0KiaL4eNZHocOVf7klivgwwS09j3LTW5D2EtFc tzV1xkLMRz9mYiCEUAVFdC1iPN1IxgIHfaNZSXVZewMVDnfFF6ZqKpQdkcEiDmwKT5X2 bFoh8H9aZtWv1aaYOqO4rK5jguz1j2+MhNW5Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=sz1Hi8LN71IdWVES3Rm3QlYRfh+YKsdF8gF0JiM3gaE=; b=mCEWpAEVdd4JMTOTdLCJR2owTNyY0VUPINP0kgdQt0W4xg7pXi2ztoASFrboPiJPeo plmyKLf1SxbOpG2RY8RH9krB07FjIT0BMSw0BIjdDcWNsMEKshrbiO/TMwsU21u1WLBg LlfXdWYKxB1NQrsf4s3DHpcvo0olFNf+0yzpD9flJ/kyE1bi9ZrmTvJWApdHBP/s0zN0 /mexj+Suvamu/SmhFWKkRnkSWONWR7rHhFbkGTvKjnt5X7sw6YhL7+7tNGTSO7wFg0tD XA+cuIjCRQoLKVvFT323SZESjPv3jJuSz4Y7EMY/wz2BktLWB+xccCwuD0jslcQAbwqc hjHw== X-Gm-Message-State: AOAM531plxfWiktIOTQi8tJEirRy51jWDuNRiV4ZpZCG3E1CAPap7ndv kN0FS/qoqo0z06E5NPxoKBXwpA== X-Google-Smtp-Source: ABdhPJxUJIVtwy2M2e2+H9SMcZh+a4/o3zUBegF6p+4tc2+h43CG5r/DLgIuUiVzlSGfYPS4GxSZCA== X-Received: by 2002:adf:ec88:: with SMTP id z8mr54954998wrn.395.1594147689016; Tue, 07 Jul 2020 11:48:09 -0700 (PDT) Received: from chromium.org (205.215.190.35.bc.googleusercontent.com. [35.190.215.205]) by smtp.gmail.com with ESMTPSA id d13sm2190919wrn.61.2020.07.07.11.48.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 11:48:08 -0700 (PDT) Date: Tue, 7 Jul 2020 18:48:07 +0000 From: Tomasz Figa To: Jonathan Bakker Cc: kyungmin.park@samsung.com, s.nawrocki@samsung.com, mchehab@kernel.org, kgene@kernel.org, krzk@kernel.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 11/11] media: exynos4-is: Correct parallel port probing Message-ID: <20200707184807.GK2621465@chromium.org> References: <20200426022650.10355-1-xc-racer2@live.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jonathan, On Sat, Apr 25, 2020 at 07:26:50PM -0700, Jonathan Bakker wrote: > According to the binding doc[1], port A should be reg = 0 > and port B reg = 1. Unfortunately, the driver was treating 0 > as invalid and 1 as camera port A. Match the binding doc and > make 0=A and 1=B. > > [1] Documentation/devicetree/bindings/media/samsung-fimc.txt > > Signed-off-by: Jonathan Bakker > --- > drivers/media/platform/exynos4-is/media-dev.c | 18 +++++++++++++----- > drivers/media/platform/exynos4-is/media-dev.h | 1 + > include/media/drv-intf/exynos-fimc.h | 2 +- > 3 files changed, 15 insertions(+), 6 deletions(-) > Thank you for the patch. Please see my comments inline. > diff --git a/drivers/media/platform/exynos4-is/media-dev.c b/drivers/media/platform/exynos4-is/media-dev.c > index a87ebd7913be..9c4fdf726b92 100644 > --- a/drivers/media/platform/exynos4-is/media-dev.c > +++ b/drivers/media/platform/exynos4-is/media-dev.c > @@ -418,13 +418,21 @@ static int fimc_md_parse_port_node(struct fimc_md *fmd, > return ret; > } > > - if (WARN_ON(endpoint.base.port == 0) || *index >= FIMC_MAX_SENSORS) { > - of_node_put(ep); > - return -EINVAL; > + if (fimc_input_is_parallel(endpoint.base.port)) { > + if (WARN_ON(*index >= FIMC_MAX_PARALLEL)) { > + of_node_put(ep); > + return -EINVAL; > + } This check seems to be generic, so could we just move it above the if/else block? > + pd->mux_id = endpoint.base.port; > + } else { > + if (WARN_ON(endpoint.base.port == 0 || Isn't this impossible, since if port == 0, the 'then' branch would've been taken instead? Best regards, Tomasz