From: "Ondřej Jirman" <megous@megous.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: linux-kernel@vger.kernel.org,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Dan Murphy <dmurphy@ti.com>,
"open list:LED SUBSYSTEM" <linux-leds@vger.kernel.org>,
marek.behun@nic.cz
Subject: Re: [PATCH RFC] leds: Add support for per-LED device triggers
Date: Sun, 12 Jul 2020 15:49:11 +0200 [thread overview]
Message-ID: <20200712134911.r3lig4hgyqhmslth@core.my.home> (raw)
In-Reply-To: <20200712072554.GC4721@duo.ucw.cz>
Hello,
On Sun, Jul 12, 2020 at 09:25:54AM +0200, Pavel Machek wrote:
> On Sat 2020-07-11 23:01:11, Ondřej Jirman wrote:
> > Hello Pavel,
> >
> > On Sat, Jul 11, 2020 at 12:04:09PM +0200, Pavel Machek wrote:
> > > Hi!
> > >
> > > > Some LED controllers may come with an internal HW triggering mechanism
> > > > for the LED and an ability to switch between user control of the LED,
> > > > or the internal control. One such example is AXP20X PMIC, that allows
> > > > wither for user control of the LED, or for internal control based on
> > > > the state of the battery charger.
> > > >
> > > > Add support for registering per-LED device trigger.
> > > >
> > > > Names of private triggers need to be globally unique, but may clash
> > > > with other private triggers. This is enforced during trigger
> > > > registration. Developers can register private triggers just like
> > > > the normal triggers, by setting private_led to a classdev
> > > > of the LED the trigger is associated with.
> > >
> > > What about this? Should address Marek's concerns about resource use...
> >
> > What concerns? Marek's concerns seem to be about case where we register
> > a trigger for (each led * self-working configuration) which I admit
> > can be quite a lot of triggers if there are many functions. But that's
> > not my proposal.
> >
> > My proposal is to only register on trigger per LED at most. So on my
> > system that's 1 extra trigger and on Marek's system that'd be 48 new
> > triggers. Neither seems like a meaningful problem from resource
> > use perspective.
>
> So.. 48 triggers on Marek's systems means I'll not apply your patch.
>
> Please take a look at my version, it is as simple and avoids that
> problem.
I would, but I don't see your version linked or mentioned in this thread.
thank you and regards,
o.
> If it works for you, you can submit it properly and I'll likely accept
> it.
>
> Best regards,
> Pavel
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2020-07-12 13:49 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 14:47 [PATCH RFC] leds: Add support for per-LED device triggers Ondrej Jirman
2020-07-02 14:51 ` Ondřej Jirman
2020-07-03 10:06 ` Marek Behún
2020-07-03 13:08 ` Ondřej Jirman
2020-07-08 14:55 ` Marek Behún
2020-07-04 12:59 ` Pavel Machek
2020-07-08 14:56 ` Marek Behún
2020-07-04 12:04 ` Pavel Machek
2020-07-04 12:17 ` Ondřej Jirman
2020-07-04 20:07 ` Pavel Machek
2020-07-11 10:04 ` Pavel Machek
2020-07-11 21:01 ` Ondřej Jirman
2020-07-12 7:25 ` Pavel Machek
2020-07-12 13:49 ` Ondřej Jirman [this message]
2020-07-12 19:11 ` Pavel Machek
2020-07-12 21:10 ` Marek Behun
2020-07-12 22:12 ` Ondřej Jirman
2020-07-12 22:38 ` Ondřej Jirman
2020-07-12 23:15 ` Marek Behun
2020-07-12 23:18 ` Marek Behun
2020-07-13 7:12 ` Pavel Machek
2020-07-12 23:20 ` Ondřej Jirman
2020-07-13 1:56 ` Ondřej Jirman
2020-07-15 17:07 ` Marek Behún
2020-07-15 17:55 ` Marek Behún
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200712134911.r3lig4hgyqhmslth@core.my.home \
--to=megous@megous.com \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=marek.behun@nic.cz \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).