From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3732FC433E1 for ; Sun, 12 Jul 2020 17:13:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 133D72067D for ; Sun, 12 Jul 2020 17:13:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=nic.cz header.i=@nic.cz header.b="V/Ue66OX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729174AbgGLRNT (ORCPT ); Sun, 12 Jul 2020 13:13:19 -0400 Received: from lists.nic.cz ([217.31.204.67]:51476 "EHLO mail.nic.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728859AbgGLRNS (ORCPT ); Sun, 12 Jul 2020 13:13:18 -0400 Received: from localhost (unknown [172.20.6.135]) by mail.nic.cz (Postfix) with ESMTPSA id D51DF13F695; Sun, 12 Jul 2020 19:13:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nic.cz; s=default; t=1594573995; bh=IdpjkEs0baFSLdPZACLe10nfwrtF82lLhF1z9A2cKrE=; h=Date:From:To; b=V/Ue66OXddxfeTBv55NCWebdOTpChau5tYqADSDnwCIjwqpDrAmn+9XP4XFlvv8bO fYWkZS8uVs19BBEK7JcGUBh4vgTA0jiJZWkuGZNkPe7Aae3xZltN5SfQyLeiYlY4/9 xH762pf8DOgvu1R3yENdXZL42rcqxWxvOxV5w+iU= Date: Sun, 12 Jul 2020 19:13:15 +0200 From: Marek Behun To: Pavel Machek Cc: Dan Murphy , jacek.anaszewski@gmail.com, robh@kernel.org, devicetree@vger.kernel.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v29 00/16] Multicolor Framework v29 Message-ID: <20200712191315.5dab10a6@nic.cz> In-Reply-To: <20200704124729.GA20088@amd> References: <20200622185919.2131-1-dmurphy@ti.com> <20200704124729.GA20088@amd> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.102.2 at mail X-Virus-Status: Clean Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 4 Jul 2020 14:47:29 +0200 Pavel Machek wrote: > Hi! > > > This is the multi color LED framework. This framework presents clustered > > colored LEDs into an array and allows the user space to adjust the brightness > > of the cluster using a single file write. The individual colored LEDs > > intensities are controlled via a single file that is an array of LEDs > > > > Change to the LEDs Kconfig to fix dependencies on the LP55XX_COMMON. > > Added update to the u8500_defconfig > > Marek, would you be willing to look over this series? Overall this series looks good to me. I wanted to apply version 29 of the patches, but I didn't receive all patches in v29 (some are missing), so I had to search for previous versions of selected patches. I have seen some typos in documentation, but that can be solved afterwards. One thing I don't like much is that in the sysfs multi_index and multi_intensity files there is a trailing space after the last color. This is not true for example for the trigger file. It is trivial to fix this, so again maybe a will send a follow-up patch after this series is accepted. Marek > Dan, can we please get it in the order > > 1) fixes first > > 2) changes needed for multicolor but not depending on dt acks > > 3) dt changes > > 4) rest? > > This is the order it should have been in the first place, and I'd like > to get fixes applied, and perhaps some of the preparation. > > Best regards, > Pavel >