From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Sibi Sankar <sibis@codeaurora.org>
Cc: agross@kernel.org, linux-arm-msm@vger.kernel.org,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
evgreen@chromium.org, ohad@wizery.com
Subject: Re: [PATCH 3/3] remoteproc: qcom_q6v5_mss: Update MBA log info
Date: Thu, 16 Jul 2020 21:59:35 -0700 [thread overview]
Message-ID: <20200717045935.GD2922385@builder.lan> (raw)
In-Reply-To: <20200716123630.21892-4-sibis@codeaurora.org>
On Thu 16 Jul 05:36 PDT 2020, Sibi Sankar wrote:
> Update MBA text logs location/size in IMEM to aid tools extract
> them after ramdump collection.
>
> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
> ---
> drivers/remoteproc/qcom_q6v5_mss.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c
> index 4ddf084b2c6fc..539594ab955f1 100644
> --- a/drivers/remoteproc/qcom_q6v5_mss.c
> +++ b/drivers/remoteproc/qcom_q6v5_mss.c
> @@ -932,6 +932,9 @@ static int q6v5_mba_load(struct q6v5 *qproc)
> if (ret)
> goto reclaim_mba;
>
> + if (qproc->has_mba_logs)
> + qcom_pil_info_store("mba", qproc->mba_phys, MBA_LOG_SIZE);
Is there a reason why we don't unconditionally write this to the PIL
info? And why it shouldn't be mba_size?
Regards,
Bjorn
> +
> ret = q6v5_rmb_mba_wait(qproc, 0, 5000);
> if (ret == -ETIMEDOUT) {
> dev_err(qproc->dev, "MBA boot timed out\n");
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
next prev parent reply other threads:[~2020-07-17 5:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 12:36 [PATCH 0/3] Add modem debug features Sibi Sankar
2020-07-16 12:36 ` [PATCH 1/3] remoteproc: qcom_q6v5_mss: Add modem debug policy support Sibi Sankar
2020-07-17 4:41 ` Bjorn Andersson
2020-07-17 5:07 ` Sibi Sankar
2020-07-16 12:36 ` [PATCH 2/3] remoteproc: qcom_q6v5_mss: Add MBA log extraction support Sibi Sankar
2020-07-16 13:43 ` Manivannan Sadhasivam
2020-07-16 14:58 ` Sibi Sankar
2020-07-17 14:38 ` Manivannan Sadhasivam
2020-07-17 4:57 ` Bjorn Andersson
2020-07-17 5:22 ` Sibi Sankar
2020-07-17 5:52 ` Bjorn Andersson
2020-07-16 12:36 ` [PATCH 3/3] remoteproc: qcom_q6v5_mss: Update MBA log info Sibi Sankar
2020-07-17 4:59 ` Bjorn Andersson [this message]
2020-07-17 5:28 ` Sibi Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200717045935.GD2922385@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=evgreen@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=sibis@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).