From: Song Liu <songliubraving@fb.com>
To: <linux-kernel@vger.kernel.org>, <bpf@vger.kernel.org>,
<netdev@vger.kernel.org>
Cc: <ast@kernel.org>, <daniel@iogearbox.net>, <kernel-team@fb.com>,
<john.fastabend@gmail.com>, <kpsingh@chromium.org>,
<brouer@redhat.com>, <dlxu@fb.com>,
Song Liu <songliubraving@fb.com>
Subject: [PATCH bpf-next 3/5] selftests/bpf: add selftest for BPF_PROG_TYPE_USER
Date: Sat, 1 Aug 2020 01:47:19 -0700 [thread overview]
Message-ID: <20200801084721.1812607-4-songliubraving@fb.com> (raw)
In-Reply-To: <20200801084721.1812607-1-songliubraving@fb.com>
This test checks the correctness of BPF_PROG_TYPE_USER program, including:
running on the right cpu, passing in correct args, returning retval, and
being able to call bpf_get_stack|stackid.
Signed-off-by: Song Liu <songliubraving@fb.com>
---
.../selftests/bpf/prog_tests/user_prog.c | 52 +++++++++++++++++
tools/testing/selftests/bpf/progs/user_prog.c | 56 +++++++++++++++++++
2 files changed, 108 insertions(+)
create mode 100644 tools/testing/selftests/bpf/prog_tests/user_prog.c
create mode 100644 tools/testing/selftests/bpf/progs/user_prog.c
diff --git a/tools/testing/selftests/bpf/prog_tests/user_prog.c b/tools/testing/selftests/bpf/prog_tests/user_prog.c
new file mode 100644
index 0000000000000..416707b3bff01
--- /dev/null
+++ b/tools/testing/selftests/bpf/prog_tests/user_prog.c
@@ -0,0 +1,52 @@
+// SPDX-License-Identifier: GPL-2.0
+/* Copyright (c) 2020 Facebook */
+#include <test_progs.h>
+#include "user_prog.skel.h"
+
+static int duration;
+
+void test_user_prog(void)
+{
+ struct bpf_user_prog_args args = {{0, 1, 2, 3, 4}};
+ struct bpf_prog_test_run_attr attr = {};
+ struct user_prog *skel;
+ int i, numcpu, ret;
+
+ skel = user_prog__open_and_load();
+
+ if (CHECK(!skel, "user_prog__open_and_load",
+ "skeleton open_and_laod failed\n"))
+ return;
+
+ numcpu = libbpf_num_possible_cpus();
+
+ attr.prog_fd = bpf_program__fd(skel->progs.user_func);
+ attr.data_size_in = sizeof(args);
+ attr.data_in = &args;
+
+ /* start from -1, so we test cpu_plus == 0 */
+ for (i = -1; i < numcpu; i++) {
+ args.args[0] = i + 1;
+ attr.cpu_plus = i + 1;
+ ret = bpf_prog_test_run_xattr(&attr);
+ CHECK(ret, "bpf_prog_test_run_xattr", "returns error\n");
+
+ /* skip two tests for i == -1 */
+ if (i == -1)
+ continue;
+ CHECK(attr.retval != i + 2, "bpf_prog_test_run_xattr",
+ "doesn't get expected retval\n");
+ CHECK(skel->data->sum != 11 + i, "user_prog_args_test",
+ "sum of args doesn't match\n");
+ }
+
+ CHECK(skel->data->cpu_match == 0, "cpu_match_test", "failed\n");
+ CHECK(skel->bss->get_stack_success != numcpu + 1, "test_bpf_get_stack",
+ "failed on %d cores\n", numcpu - skel->bss->get_stack_success);
+ CHECK(skel->bss->get_stackid_success != numcpu + 1,
+ "test_bpf_get_stackid",
+ "failed on %d cores\n",
+ numcpu + 1 - skel->bss->get_stackid_success);
+
+ user_prog__destroy(skel);
+}
diff --git a/tools/testing/selftests/bpf/progs/user_prog.c b/tools/testing/selftests/bpf/progs/user_prog.c
new file mode 100644
index 0000000000000..cf320e97f107a
--- /dev/null
+++ b/tools/testing/selftests/bpf/progs/user_prog.c
@@ -0,0 +1,56 @@
+// SPDX-License-Identifier: GPL-2.0
+/* Copyright (c) 2020 Facebook */
+#include "vmlinux.h"
+#include <bpf/bpf_helpers.h>
+#include <bpf/bpf_tracing.h>
+
+char _license[] SEC("license") = "GPL";
+
+#ifndef PERF_MAX_STACK_DEPTH
+#define PERF_MAX_STACK_DEPTH 127
+#endif
+
+typedef __u64 stack_trace_t[PERF_MAX_STACK_DEPTH];
+
+struct {
+ __uint(type, BPF_MAP_TYPE_STACK_TRACE);
+ __uint(max_entries, 16384);
+ __uint(key_size, sizeof(__u32));
+ __uint(value_size, sizeof(stack_trace_t));
+} stackmap SEC(".maps");
+
+volatile int cpu_match = 1;
+volatile __u64 sum = 1;
+volatile int get_stack_success = 0;
+volatile int get_stackid_success = 0;
+volatile __u64 stacktrace[PERF_MAX_STACK_DEPTH];
+
+SEC("user")
+int user_func(struct bpf_user_prog_ctx *ctx)
+{
+ int cpu = bpf_get_smp_processor_id();
+ __u32 key = cpu;
+ long stackid, err;
+
+ /* check the program runs on the right cpu */
+ if (ctx->args[0] && ctx->args[0] != cpu + 1)
+ cpu_match = 0;
+
+ /* check the sum of arguments are correct */
+ sum = ctx->args[0] + ctx->args[1] + ctx->args[2] +
+ ctx->args[3] + ctx->args[4];
+
+ /* check bpf_get_stackid works */
+ stackid = bpf_get_stackid(ctx, &stackmap, 0);
+ if (stackid >= 0)
+ get_stackid_success++;
+
+ /* check bpf_get_stack works */
+ err = bpf_get_stack(ctx, (void *)stacktrace,
+ PERF_MAX_STACK_DEPTH * sizeof(__u64),
+ BPF_F_USER_STACK);
+ if (err >= 0)
+ get_stack_success++;
+
+ return cpu + 2;
+}
--
2.24.1
next prev parent reply other threads:[~2020-08-01 8:49 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-01 8:47 [PATCH bpf-next 0/5] introduce BPF_PROG_TYPE_USER Song Liu
2020-08-01 8:47 ` [PATCH bpf-next 1/5] bpf: " Song Liu
2020-08-01 13:58 ` kernel test robot
2020-08-01 15:21 ` kernel test robot
2020-08-06 18:18 ` kernel test robot
2020-08-06 18:18 ` [RFC PATCH] bpf: user_verifier_ops can be static kernel test robot
2020-08-01 8:47 ` [PATCH bpf-next 2/5] libbpf: support BPF_PROG_TYPE_USER programs Song Liu
2020-08-03 1:40 ` Andrii Nakryiko
2020-08-03 4:21 ` Song Liu
2020-08-03 5:05 ` Andrii Nakryiko
2020-08-04 1:18 ` Song Liu
2020-08-05 1:38 ` Andrii Nakryiko
2020-08-05 3:59 ` Song Liu
2020-08-05 5:32 ` Andrii Nakryiko
2020-08-05 6:26 ` Song Liu
2020-08-05 6:54 ` Andrii Nakryiko
2020-08-05 7:23 ` Song Liu
2020-08-05 17:44 ` Andrii Nakryiko
2020-08-01 8:47 ` Song Liu [this message]
2020-08-03 1:43 ` [PATCH bpf-next 3/5] selftests/bpf: add selftest for BPF_PROG_TYPE_USER Andrii Nakryiko
2020-08-03 4:33 ` Song Liu
2020-08-03 5:07 ` Andrii Nakryiko
2020-08-01 8:47 ` [PATCH bpf-next 4/5] selftests/bpf: move two functions to test_progs.c Song Liu
2020-08-03 1:46 ` Andrii Nakryiko
2020-08-03 4:34 ` Song Liu
2020-08-01 8:47 ` [PATCH bpf-next 5/5] selftests/bpf: add benchmark for uprobe vs. user_prog Song Liu
2020-08-03 1:51 ` Andrii Nakryiko
2020-08-03 4:47 ` Song Liu
2020-08-03 5:10 ` Andrii Nakryiko
2020-08-04 20:54 ` Song Liu
2020-08-05 1:52 ` Andrii Nakryiko
2020-08-05 4:47 ` Song Liu
2020-08-05 5:47 ` Andrii Nakryiko
2020-08-05 7:01 ` Song Liu
2020-08-05 17:39 ` Andrii Nakryiko
2020-08-05 18:41 ` Song Liu
2020-08-05 17:16 ` Alexei Starovoitov
2020-08-05 17:27 ` Andrii Nakryiko
2020-08-05 17:45 ` Alexei Starovoitov
2020-08-05 17:56 ` Andrii Nakryiko
2020-08-05 18:56 ` Song Liu
2020-08-05 22:50 ` Alexei Starovoitov
2020-08-05 23:50 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200801084721.1812607-4-songliubraving@fb.com \
--to=songliubraving@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=dlxu@fb.com \
--cc=john.fastabend@gmail.com \
--cc=kernel-team@fb.com \
--cc=kpsingh@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).