From: mcsmonk <mcsmonk@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Sunghyun Jin <mcsmonk@gmail.com>
Subject: [PATCH] mm/percpu.c: Modify size of populated bitmap of chunk for memory allocation
Date: Sun, 2 Aug 2020 21:12:43 +0900 [thread overview]
Message-ID: <20200802121243.15148-1-mcsmonk@gmail.com> (raw)
In-Reply-To: <dennis@kernel.org; tj@kernel.org; cl@linux.com; akpm@linux-foundation.org>
From: Sunghyun Jin <mcsmonk@gmail.com>
Variable populated, which is a member of struct pcpu_chunk, is used as a
unit of size of unsigned long in below code:
```
1142 /* manage populated page bitmap */
1143 chunk->immutable = true;
1144 bitmap_fill(chunk->populated, chunk->nr_pages);
```
```
230 static inline void bitmap_fill(unsigned long *dst, unsigned int
nbits)
231 {
232 unsigned int len = BITS_TO_LONGS(nbits)
* sizeof(unsigned long);
233 memset(dst, 0xff, len);
234 }
```
However, size of populated is miscounted. So, I fix this minor
part.
Signed-off-by: Sunghyun Jin <mcsmonk@gmail.com>
---
mm/percpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/percpu.c b/mm/percpu.c
index 696367b18222..d83e0032cb20 100644
--- a/mm/percpu.c
+++ b/mm/percpu.c
@@ -1300,7 +1300,7 @@ static struct pcpu_chunk * __init pcpu_alloc_first_chunk(unsigned long tmp_addr,
/* allocate chunk */
alloc_size = sizeof(struct pcpu_chunk) +
- BITS_TO_LONGS(region_size >> PAGE_SHIFT);
+ BITS_TO_LONGS(region_size >> PAGE_SHIFT) * sizeof(unsigned long);
chunk = memblock_alloc(alloc_size, SMP_CACHE_BYTES);
if (!chunk)
panic("%s: Failed to allocate %zu bytes\n", __func__,
--
2.17.1
parent reply other threads:[~2020-08-02 12:12 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <dennis@kernel.org; tj@kernel.org; cl@linux.com; akpm@linux-foundation.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200802121243.15148-1-mcsmonk@gmail.com \
--to=mcsmonk@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).