From: "Ramuthevar,Vadivel MuruganX" <vadivel.muruganx.ramuthevar@linux.intel.com>
To: linux-kernel@vger.kernel.org, myungjoo.ham@samsung.com,
cw00.choi@samsung.com
Cc: andriy.shevchenko@intel.com, thomas.langer@intel.com,
cheol.yong.kim@intel.com, qi-ming.wu@intel.com,
yin1.li@intel.com,
Ramuthevar Vadivel Murugan
<vadivel.muruganx.ramuthevar@linux.intel.com>
Subject: [PATCH v1 1/9] extcon: extcon-ptn5150: Switch to GENMASK() for vendor and device ID's
Date: Tue, 18 Aug 2020 14:57:19 +0800 [thread overview]
Message-ID: <20200818065727.50520-2-vadivel.muruganx.ramuthevar@linux.intel.com> (raw)
In-Reply-To: <20200818065727.50520-1-vadivel.muruganx.ramuthevar@linux.intel.com>
From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
Switch to GENMASK() for vendor_id and device_id macros.
Signed-off-by: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
---
drivers/extcon/extcon-ptn5150.c | 16 +++++-----------
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/drivers/extcon/extcon-ptn5150.c b/drivers/extcon/extcon-ptn5150.c
index d1c997599390..5d9a8767646b 100644
--- a/drivers/extcon/extcon-ptn5150.c
+++ b/drivers/extcon/extcon-ptn5150.c
@@ -6,6 +6,7 @@
// Copyright (c) 2018-2019 by Vijai Kumar K
// Author: Vijai Kumar K <vijaikumar.kanagarajan@gmail.com>
+#include <linux/bitfield.h>
#include <linux/err.h>
#include <linux/i2c.h>
#include <linux/interrupt.h>
@@ -34,13 +35,8 @@ enum ptn5150_reg {
#define PTN5150_UFP_ATTACHED 0x2
/* Define PTN5150 MASK/SHIFT constant */
-#define PTN5150_REG_DEVICE_ID_VENDOR_SHIFT 0
-#define PTN5150_REG_DEVICE_ID_VENDOR_MASK \
- (0x3 << PTN5150_REG_DEVICE_ID_VENDOR_SHIFT)
-
-#define PTN5150_REG_DEVICE_ID_VERSION_SHIFT 3
-#define PTN5150_REG_DEVICE_ID_VERSION_MASK \
- (0x1f << PTN5150_REG_DEVICE_ID_VERSION_SHIFT)
+#define PTN5150_REG_DEVICE_ID_VERSION GENMASK(7, 3)
+#define PTN5150_REG_DEVICE_ID_VENDOR GENMASK(2, 0)
#define PTN5150_REG_CC_PORT_ATTACHMENT_SHIFT 2
#define PTN5150_REG_CC_PORT_ATTACHMENT_MASK \
@@ -194,10 +190,8 @@ static int ptn5150_init_dev_type(struct ptn5150_info *info)
return -EINVAL;
}
- vendor_id = ((reg_data & PTN5150_REG_DEVICE_ID_VENDOR_MASK) >>
- PTN5150_REG_DEVICE_ID_VENDOR_SHIFT);
- version_id = ((reg_data & PTN5150_REG_DEVICE_ID_VERSION_MASK) >>
- PTN5150_REG_DEVICE_ID_VERSION_SHIFT);
+ vendor_id = FIELD_GET(PTN5150_REG_DEVICE_ID_VENDOR, reg_data);
+ version_id = FIELD_GET(PTN5150_REG_DEVICE_ID_VERSION, reg_data);
dev_info(info->dev, "Device type: version: 0x%x, vendor: 0x%x\n",
version_id, vendor_id);
--
2.11.0
next prev parent reply other threads:[~2020-08-18 6:57 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 6:57 [PATCH v1 0/9] extcon: extcon-ptn5150: Add the USB external connector support Ramuthevar,Vadivel MuruganX
2020-08-18 6:57 ` Ramuthevar,Vadivel MuruganX [this message]
2020-08-26 6:57 ` [PATCH v1 1/9] extcon: extcon-ptn5150: Switch to GENMASK() for vendor and device ID's Krzysztof Kozlowski
2020-08-18 6:57 ` [PATCH v1 2/9] extcon: extcon-ptn5150: Switch to GENMASK() for VBUS detection macro Ramuthevar,Vadivel MuruganX
2020-08-26 6:59 ` Krzysztof Kozlowski
2020-08-26 7:33 ` Ramuthevar, Vadivel MuruganX
2020-08-18 6:57 ` [PATCH v1 3/9] extcon: extcon-ptn5150: Switch to BIT() macro for cable attach Ramuthevar,Vadivel MuruganX
2020-08-26 6:59 ` Krzysztof Kozlowski
2020-08-26 7:50 ` Ramuthevar, Vadivel MuruganX
2020-08-18 6:57 ` [PATCH v1 4/9] extcon: extcon-ptn5150: Switch to BIT() for cable detach macro Ramuthevar,Vadivel MuruganX
2020-08-26 7:00 ` Krzysztof Kozlowski
2020-08-18 6:57 ` [PATCH v1 5/9] extcon: extcon-ptn5150: Switch to GENMASK() for port attachment macro Ramuthevar,Vadivel MuruganX
2020-08-26 7:00 ` Krzysztof Kozlowski
2020-08-18 6:57 ` [PATCH v1 6/9] extcon: extcon-ptn5150: Set and get the VBUS and POLARITY property state Ramuthevar,Vadivel MuruganX
2020-08-18 6:57 ` [PATCH v1 7/9] extcon: extcon-ptn5150: Add USB debug accessory support Ramuthevar,Vadivel MuruganX
2020-08-18 6:57 ` [PATCH v1 8/9] extcon: extcon-ptn5150: Add USB analog audio " Ramuthevar,Vadivel MuruganX
2020-08-18 6:57 ` [PATCH v1 9/9] extcon: extcon-ptn5150: Remove unused variable and extra space Ramuthevar,Vadivel MuruganX
2020-08-18 8:40 ` [PATCH v1 0/9] extcon: extcon-ptn5150: Add the USB external connector support Andy Shevchenko
2020-08-19 5:35 ` Ramuthevar, Vadivel MuruganX
2020-08-19 7:55 ` Andy Shevchenko
2020-08-19 8:45 ` Ramuthevar, Vadivel MuruganX
2020-08-25 8:19 ` Heikki Krogerus
2020-08-26 2:51 ` Ramuthevar, Vadivel MuruganX
2020-08-26 9:18 ` Andy Shevchenko
2020-08-26 9:43 ` Ramuthevar, Vadivel MuruganX
2020-08-26 9:50 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200818065727.50520-2-vadivel.muruganx.ramuthevar@linux.intel.com \
--to=vadivel.muruganx.ramuthevar@linux.intel.com \
--cc=andriy.shevchenko@intel.com \
--cc=cheol.yong.kim@intel.com \
--cc=cw00.choi@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=qi-ming.wu@intel.com \
--cc=thomas.langer@intel.com \
--cc=yin1.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).