From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Scott Branden <scott.branden@broadcom.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Kees Cook <keescook@chromium.org>,
linux-kernel@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH v2 1/3] bcm-vk: add bcm_vk UAPI
Date: Tue, 18 Aug 2020 15:53:13 +0200 [thread overview]
Message-ID: <20200818135313.GB495837@kroah.com> (raw)
In-Reply-To: <20200806004631.8102-2-scott.branden@broadcom.com>
On Wed, Aug 05, 2020 at 05:46:29PM -0700, Scott Branden wrote:
> Add user space api for bcm-vk driver.
>
> Signed-off-by: Scott Branden <scott.branden@broadcom.com>
> ---
> include/uapi/linux/misc/bcm_vk.h | 99 ++++++++++++++++++++++++++++++++
> 1 file changed, 99 insertions(+)
> create mode 100644 include/uapi/linux/misc/bcm_vk.h
>
> diff --git a/include/uapi/linux/misc/bcm_vk.h b/include/uapi/linux/misc/bcm_vk.h
> new file mode 100644
> index 000000000000..783087b7c31f
> --- /dev/null
> +++ b/include/uapi/linux/misc/bcm_vk.h
> @@ -0,0 +1,99 @@
> +/* SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) */
> +/*
> + * Copyright 2018-2020 Broadcom.
> + */
> +
> +#ifndef __UAPI_LINUX_MISC_BCM_VK_H
> +#define __UAPI_LINUX_MISC_BCM_VK_H
> +
> +#include <linux/ioctl.h>
> +#include <linux/types.h>
> +
> +#define BCM_VK_MAX_FILENAME 64
> +
> +struct vk_image {
> + __u32 type; /* Type of image */
> +#define VK_IMAGE_TYPE_BOOT1 1 /* 1st stage (load to SRAM) */
> +#define VK_IMAGE_TYPE_BOOT2 2 /* 2nd stage (load to DDR) */
> + char filename[BCM_VK_MAX_FILENAME]; /* Filename of image */
> +};
> +
> +struct vk_reset {
> + __u32 arg1;
> + __u32 arg2;
> +};
> +
> +#define VK_MAGIC 0x5e
> +
> +/* Load image to Valkyrie */
> +#define VK_IOCTL_LOAD_IMAGE _IOW(VK_MAGIC, 0x2, struct vk_image)
> +
> +/* Send Reset to Valkyrie */
> +#define VK_IOCTL_RESET _IOW(VK_MAGIC, 0x4, struct vk_reset)
> +
> +/*
> + * message block - basic unit in the message where a message's size is always
> + * N x sizeof(basic_block)
> + */
> +struct vk_msg_blk {
> + __u8 function_id;
> +#define VK_FID_TRANS_BUF 5
> +#define VK_FID_SHUTDOWN 8
> + __u8 size;
> + __u16 trans_id; /* transport id, queue & msg_id */
> + __u32 context_id;
> + __u32 args[2];
> +#define VK_CMD_PLANES_MASK 0x000f /* number of planes to up/download */
> +#define VK_CMD_UPLOAD 0x0400 /* memory transfer to vk */
> +#define VK_CMD_DOWNLOAD 0x0500 /* memory transfer from vk */
> +#define VK_CMD_MASK 0x0f00 /* command mask */
> +};
> +
> +#define VK_BAR_FWSTS 0x41c
> +#define VK_BAR_COP_FWSTS 0x428
> +/* VK_FWSTS definitions */
> +#define VK_FWSTS_RELOCATION_ENTRY BIT(0)
<snip>
I thought BIT() was not allowed in uapi .h files, this really works
properly???
thanks,
greg k-h
next prev parent reply other threads:[~2020-08-18 13:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-06 0:46 [PATCH v2 0/3] Add Broadcom VK driver Scott Branden
2020-08-06 0:46 ` [PATCH v2 1/3] bcm-vk: add bcm_vk UAPI Scott Branden
2020-08-18 13:53 ` Greg Kroah-Hartman [this message]
2020-08-18 17:23 ` Scott Branden
2020-08-18 17:44 ` Greg Kroah-Hartman
2020-08-19 0:35 ` Scott Branden
2020-08-19 7:00 ` Greg Kroah-Hartman
2020-08-20 16:37 ` Scott Branden
2020-08-20 20:55 ` Kees Cook
2020-08-20 20:57 ` Florian Fainelli
2020-08-20 21:10 ` Scott Branden
2020-08-20 21:09 ` Scott Branden
2020-08-06 0:46 ` [PATCH v2 2/3] misc: bcm-vk: add Broadcom VK driver Scott Branden
2020-08-06 0:46 ` [PATCH v2 3/3] MAINTAINERS: bcm-vk: add maintainer for Broadcom VK Driver Scott Branden
2020-08-18 19:52 ` [PATCH v2 0/3] Add Broadcom VK driver Kees Cook
2020-08-19 5:53 ` Greg Kroah-Hartman
-- strict thread matches above, loose matches on Subject: below --
2020-07-31 18:52 Scott Branden
2020-07-31 18:52 ` [PATCH v2 1/3] bcm-vk: add bcm_vk UAPI Scott Branden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200818135313.GB495837@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=scott.branden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).