From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1B20C433E1 for ; Fri, 21 Aug 2020 11:39:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 85251207BB for ; Fri, 21 Aug 2020 11:39:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728602AbgHULjS (ORCPT ); Fri, 21 Aug 2020 07:39:18 -0400 Received: from asavdk3.altibox.net ([109.247.116.14]:39102 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728344AbgHULiS (ORCPT ); Fri, 21 Aug 2020 07:38:18 -0400 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 96E5E2001E; Fri, 21 Aug 2020 13:38:11 +0200 (CEST) Date: Fri, 21 Aug 2020 13:38:09 +0200 From: Sam Ravnborg To: Enric Balletbo i Serra Cc: Jernej Skrabec , drinkcat@chromium.org, Neil Armstrong , David Airlie , Jonas Karlman , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Andrzej Hajda , Boris Brezillon , Laurent Pinchart , hsinyi@chromium.org, matthias.bgg@gmail.com, Collabora Kernel ML Subject: Re: [PATCH 3/3] drm/bridge: ps8640: Rework power state handling Message-ID: <20200821113809.GA283294@ravnborg.org> References: <20200615205320.790334-1-enric.balletbo@collabora.com> <20200615205320.790334-4-enric.balletbo@collabora.com> <20200620214225.GD74146@ravnborg.org> <0220cfe5-2ac9-2d8b-529d-bb1a61478395@collabora.com> <20200624070738.GA1807736@ravnborg.org> <20b2f097-d789-3f5a-cd7e-3701669f43cb@collabora.com> <5af757da-87ec-c0d1-374d-0a69401e09a3@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5af757da-87ec-c0d1-374d-0a69401e09a3@collabora.com> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=f+hm+t6M c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=WqFqRLcIwFt0jbhFSLsA:9 a=CjuIK1q_8ugA:10 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Enric. > > Let me reformulate the question for if it was not clear. > > What I did is be able to read the EDID every time userspace asks for it (so > kernel enables all the required) and Sam is proposing to just fail if all is not > setup. I can obviously do this but my question is, at which point I should leave > all the logic enabled to be able to read the EDID (after probe?, after > pre_enable, after enable?) It is not clear for me from the API. I am not clear if my suggestion is a good suggestion. I recall I saw something similar in another bridge driver. If no-one else chimes in then go ahead with your original approach where there is less restriction when it is possible to read edid. Sam