From: Herbert Xu <herbert@gondor.apana.org.au>
To: George Acosta <acostag.ubuntu@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Phani Kiran Hemadri <phemadri@marvell.com>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crypto: cavium/nitrox: add an error message to explain the failure of pci_request_mem_regions
Date: Sat, 29 Aug 2020 22:04:09 +1000 [thread overview]
Message-ID: <20200829120409.GA22368@gondor.apana.org.au> (raw)
In-Reply-To: <CALhW5_QpsRCb73OCiOKC0xVSwuadz3BVSQg+r=T4AN+qCpSM0w@mail.gmail.com>
On Fri, Aug 28, 2020 at 08:53:36PM -0500, George Acosta wrote:
> Hi Herbert,
> I just noticed a small potential issue about the calling sequence of
> pci_disable_device and dev_err.
> Do you think it will be better to call dev_err before we call
> pci_disable_device(pdev) , or the order here does not matter?
I don't think it matters.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2020-08-29 12:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 3:12 [PATCH] crypto: cavium/nitrox: add an error message to explain the failure of pci_request_mem_regions George Acosta
2020-08-28 7:19 ` Herbert Xu
2020-08-29 1:53 ` George Acosta
2020-08-29 12:04 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200829120409.GA22368@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=acostag.ubuntu@gmail.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=davem@davemloft.net \
--cc=gustavo@embeddedor.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phemadri@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).