From: Sakari Ailus <sakari.ailus@iki.fi>
To: Sowjanya Komatineni <skomatineni@nvidia.com>
Cc: Jacopo Mondi <jacopo@jmondi.org>,
thierry.reding@gmail.com, jonathanh@nvidia.com,
hverkuil@xs4all.nl, jacopo+renesas@jmondi.org,
luca@lucaceresoli.net, leonl@leopardimaging.com,
robh+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/3] dt-bindings: media: imx274: Add optional input clock and supplies
Date: Tue, 8 Sep 2020 12:33:41 +0300 [thread overview]
Message-ID: <20200908093341.GB834@valkosipuli.retiisi.org.uk> (raw)
In-Reply-To: <f38bb328-b282-783b-3ac5-5441001d10b6@nvidia.com>
On Thu, Sep 03, 2020 at 09:40:57AM -0700, Sowjanya Komatineni wrote:
>
> On 9/3/20 9:35 AM, Jacopo Mondi wrote:
> > Hi Sowjanya,
> >
> > On Thu, Sep 03, 2020 at 09:05:27AM -0700, Sowjanya Komatineni wrote:
> > > On 9/3/20 5:55 AM, Jacopo Mondi wrote:
> > > > Hello Sowjanya,
> > > >
> > > > On Tue, Sep 01, 2020 at 07:04:37PM -0700, Sowjanya Komatineni wrote:
> > > > > This patch adds IMX274 optional external clock input and voltage
> > > > > supplies to device tree bindings.
> > > > >
> > > > > Reviewed-by: Luca Ceresoli <luca@lucaceresoli.net>
> > > > > Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
> > > > > ---
> > > > > .../devicetree/bindings/media/i2c/sony,imx274.yaml | 21 +++++++++++++++++++++
> > > > > 1 file changed, 21 insertions(+)
> > > > >
> > > > > diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
> > > > > index 7ae47a6..57e7176 100644
> > > > > --- a/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
> > > > > +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
> > > > > @@ -25,6 +25,27 @@ properties:
> > > > > reset-gpios:
> > > > > maxItems: 1
> > > > >
> > > > I just sent an update to my json-schema conversion of this bindings
> > > > document (not yet on patchwork, sorry) and Sakari pointed me to the
> > > > fact in between my v2 and my v4 this patch from you went in:
> > > > 4ea3273d24b ("dt-bindings: media: imx274: Add optional input clock and supplies")
> > > >
> > > > I should probably now update my bindings conversion patch, basically
> > > > taking in what you've done here, but I would have one question.
> > > >
> > > > > + clocks:
> > > > > + maxItems: 1
> > > > > + description: Reference to the sensor input clock
> > > > > +
> > > > > + clock-names:
> > > > > + maxItems: 1
> > > > > + items:
> > > > > + - const: inck
> > > > > +
> > > > > + vana-supply:
> > > > > + description:
> > > > > + Analog voltage supply, 2.8 volts
> > > > > +
> > > > > + vdig-supply:
> > > > > + description:
> > > > > + Digital IO voltage supply, 1.8 volts
> > > > > +
> > > > > + vddl-supply:
> > > > > + description:
> > > > > + Digital core voltage supply, 1.2 volts
> > > > 4ea3273d24b introduced these regulators as VANA-supply, VDIG-supply
> > > > and VDDL-supply (please note the upper-case names). This version uses
> > > > lower-case ones instead. Is this intentional ? The driver currently
> > > > does not parse any of these if I'm not mistaken, but as the bindings
> > > > in textual form defines an ABI which should be preserved during the
> > > > conversion to json-schema, should these be kept in upper-case ?
> > > >
> > > > Thanks
> > > > j
> > > Yes, based on feedback lower case was recommended. So, changed to use
> > > lower-case names.
> > >
> > > These properties were not used by driver currently and from my prior series
> > > only dt-binding got merged as no feedback was received on it for all prior
> > > versions.
> > >
> > > So, should be ok to change to lower-case as there properties are introduced
> > > now and driver update using these properties is under review
> > >
> > Well, I see that patch went in v5.9-rc1, so it will be part of v5.9.
> >
> > If the bindings update goes in in v5.10 (or whatever comes after v5.9)
> > then we have a problem, as the DTB created for v5.9 won't work anymore
> > on any later version, and that should not happen. Alternatively, a fix
> > for the next -rc release could be fast-tracked, but you would
> > need to synchronize with the dt maintainers for that and make a patch
> > for the existing .txt bindings file.
> >
> > If the name change happens in the yaml file and one release is made
> > with the old names, then we're stuck with those forever and ever, if I
> > got the situation right.
> >
> > Please check with the dt and media maintainers, or they can comment
> > here if they glance through these lines.
> >
> > Thanks
> > j
>
> Hi Leon Luo,
>
> I used upper case for regulator supply names in all prior 4 versions of
> IMX274 patch series as I see some other media i2c drivers doing it and
> dt-binding patch from v3 got merged in 5.9-rc1 which was using upper-case.
>
> Later received feedback from Sakari requesting to use lower-case names so
> updated to use lower case name now in v5.
>
> Not sure if we have timeline to squeeze in patch to change names to
> lower-case before they get into 5.10.
>
> Can you please comment?
We can merge patches through the fixes branch if needed. That is not an
issue.
>
> Sakari,
>
> Can you also help understand why can't we keep upper case for regulator
> supplies?
>
> I see some other media i2c drivers using upper case as well.
The vast majority of bindings use lower case, that's it, simply.
--
Regards,
Sakari Ailus
next prev parent reply other threads:[~2020-09-08 9:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 2:04 [PATCH v5 0/3] IMX274 fixes and power on and off implementation Sowjanya Komatineni
2020-09-02 2:04 ` [PATCH v5 1/3] media: i2c: imx274: Fix Y_OUT_SIZE register setting Sowjanya Komatineni
2020-09-02 2:04 ` [PATCH v5 2/3] dt-bindings: media: imx274: Add optional input clock and supplies Sowjanya Komatineni
2020-09-02 6:46 ` Luca Ceresoli
2020-09-02 6:52 ` Luca Ceresoli
2020-09-03 12:55 ` Jacopo Mondi
2020-09-03 16:05 ` Sowjanya Komatineni
2020-09-03 16:35 ` Jacopo Mondi
2020-09-03 16:40 ` Sowjanya Komatineni
2020-09-08 9:33 ` Sakari Ailus [this message]
2020-09-08 14:34 ` Jacopo Mondi
2020-09-08 18:10 ` Sowjanya Komatineni
2020-09-02 2:04 ` [PATCH v5 3/3] media: i2c: imx274: Add IMX274 power on and off sequence Sowjanya Komatineni
2020-09-03 15:03 ` Jacopo Mondi
2020-09-03 16:25 ` Sowjanya Komatineni
2020-09-04 8:55 ` Jacopo Mondi
[not found] ` <5ebe8d22-86fb-7bf2-ab19-e729caf8d88f@nvidia.com>
2020-09-07 7:48 ` Jacopo Mondi
2020-09-08 18:13 ` Sowjanya Komatineni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200908093341.GB834@valkosipuli.retiisi.org.uk \
--to=sakari.ailus@iki.fi \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=jacopo+renesas@jmondi.org \
--cc=jacopo@jmondi.org \
--cc=jonathanh@nvidia.com \
--cc=leonl@leopardimaging.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=luca@lucaceresoli.net \
--cc=robh+dt@kernel.org \
--cc=skomatineni@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).