From: Borislav Petkov <bp@alien8.de>
To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>,
kitsunyan <kitsunyan@airmail.cc>,
"Brown, Len" <len.brown@intel.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/msr: do not warn on writes to OC_MAILBOX
Date: Tue, 8 Sep 2020 19:31:28 +0200 [thread overview]
Message-ID: <20200908173128.GH25236@zn.tnic> (raw)
In-Reply-To: <22617e57e541e460fac09db04fdb370f8e96e8ef.camel@linux.intel.com>
On Tue, Sep 08, 2020 at 10:10:17AM -0700, Srinivas Pandruvada wrote:
> > > - if (reg == MSR_IA32_ENERGY_PERF_BIAS)
> > > + switch (reg) {
> > > + case MSR_IA32_ENERGY_PERF_BIAS:
> There is already sysfs interface for it.
So someone needs to convert all those to it:
tools/power/cpupower/utils/helpers/msr.c:14:#define MSR_IA32_ENERGY_PERF_BIAS 0x1b0
tools/power/cpupower/utils/helpers/msr.c:84: ret = read_msr(cpu, MSR_IA32_ENERGY_PERF_BIAS, &val);
tools/power/cpupower/utils/helpers/msr.c:97: ret = write_msr(cpu, MSR_IA32_ENERGY_PERF_BIAS, val);
tools/power/x86/turbostat/turbostat.8:222:cpu0: MSR_IA32_ENERGY_PERF_BIAS: 0x00000006 (balanced)
tools/power/x86/turbostat/turbostat.c:3652: if (get_msr(cpu, MSR_IA32_ENERGY_PERF_BIAS, &msr))
tools/power/x86/turbostat/turbostat.c:3669: fprintf(outf, "cpu%d: MSR_IA32_ENERGY_PERF_BIAS: 0x%08llx (%s)\n", cpu, msr, epb_string);
tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.8:25:Policy in MSR_IA32_ENERGY_PERF_BIAS (EPB)
tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.8:33:Note that MSR_IA32_ENERGY_PERF_BIAS is defined per CPU,
tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c:84:unsigned int has_epb; /* MSR_IA32_ENERGY_PERF_BIAS */
tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c:755: get_msr(cpu, MSR_IA32_ENERGY_PERF_BIAS, &msr);
tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c:1044: get_msr(cpu, MSR_IA32_ENERGY_PERF_BIAS, &msr);
tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c:1045: put_msr(cpu, MSR_IA32_ENERGY_PERF_BIAS, new_epb);
Any takers?
If there are none, it could be made into a small kernelnewbies
project...
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
prev parent reply other threads:[~2020-09-08 17:32 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 9:48 [PATCH] x86/msr: do not warn on writes to OC_MAILBOX Jason A. Donenfeld
2020-09-07 10:06 ` Borislav Petkov
2020-09-07 10:46 ` Jason A. Donenfeld
2020-09-07 11:11 ` Borislav Petkov
2020-09-07 11:15 ` Jason A. Donenfeld
2020-09-07 11:23 ` Borislav Petkov
2020-09-08 17:10 ` Srinivas Pandruvada
2020-09-08 17:12 ` Jason A. Donenfeld
2020-09-08 17:25 ` Borislav Petkov
2020-09-08 17:29 ` Jason A. Donenfeld
2020-09-08 17:36 ` Borislav Petkov
2020-09-08 17:42 ` Jason A. Donenfeld
2020-09-08 18:01 ` Borislav Petkov
2020-09-08 19:07 ` Jason A. Donenfeld
2020-09-08 19:18 ` Sultan Alsawaf
2020-09-08 19:30 ` Borislav Petkov
2020-09-08 20:35 ` Andy Lutomirski
2020-09-08 22:32 ` Matthew Garrett
2020-09-09 23:56 ` Andy Lutomirski
2020-09-09 1:02 ` Srinivas Pandruvada
2020-09-10 0:08 ` Andy Lutomirski
2020-10-19 17:15 ` Borislav Petkov
2020-10-20 17:21 ` Srinivas Pandruvada
2020-10-20 17:47 ` Borislav Petkov
2020-10-20 18:40 ` Srinivas Pandruvada
2020-10-20 19:40 ` Dave Hansen
2020-10-21 13:11 ` Srinivas Pandruvada
2020-10-22 19:28 ` Borislav Petkov
2020-10-21 13:24 ` Peter Zijlstra
2020-09-08 17:31 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200908173128.GH25236@zn.tnic \
--to=bp@alien8.de \
--cc=Jason@zx2c4.com \
--cc=kitsunyan@airmail.cc \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).