From: Herbert Xu <herbert@gondor.apana.org.au>
To: Nicolas Toromanoff <nicolas.toromanoff@st.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Ard Biesheuvel <ardb@kernel.org>,
linux-crypto@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crypto: stm32/crc32 - Avoid lock if hardware is already used
Date: Fri, 11 Sep 2020 14:28:16 +1000 [thread overview]
Message-ID: <20200911042816.GA5531@gondor.apana.org.au> (raw)
In-Reply-To: <20200904112527.15677-1-nicolas.toromanoff@st.com>
On Fri, Sep 04, 2020 at 01:25:27PM +0200, Nicolas Toromanoff wrote:
> If STM32 CRC device is already in use, calculate CRC by software.
>
> This will release CPU constraint for a concurrent access to the
> hardware, and avoid masking irqs during the whole block processing.
>
> Fixes: 7795c0baf5ac ("crypto: stm32/crc32 - protect from concurrent accesses")
>
> Signed-off-by: Nicolas Toromanoff <nicolas.toromanoff@st.com>
> ---
> drivers/crypto/stm32/Kconfig | 2 ++
> drivers/crypto/stm32/stm32-crc32.c | 15 ++++++++++++---
> 2 files changed, 14 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/crypto/stm32/Kconfig b/drivers/crypto/stm32/Kconfig
> index 4ef3eb11361c..8d605b07571f 100644
> --- a/drivers/crypto/stm32/Kconfig
> +++ b/drivers/crypto/stm32/Kconfig
> @@ -3,6 +3,8 @@ config CRYPTO_DEV_STM32_CRC
> tristate "Support for STM32 crc accelerators"
> depends on ARCH_STM32
> select CRYPTO_HASH
> + select CRYPTO_CRC32
> + select CRYPTO_CRC32C
Shouldn't this be "select CRC32"?
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2020-09-11 4:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-04 11:25 [PATCH] crypto: stm32/crc32 - Avoid lock if hardware is already used Nicolas Toromanoff
2020-09-11 4:28 ` Herbert Xu [this message]
2020-09-15 15:54 ` Nicolas TOROMANOFF
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200911042816.GA5531@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=alexandre.torgue@st.com \
--cc=ardb@kernel.org \
--cc=davem@davemloft.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=nicolas.toromanoff@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).