From: Peter Zijlstra <peterz@infradead.org>
To: Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc: tglx@linutronix.de, mingo@kernel.org,
linux-kernel@vger.kernel.org, bigeasy@linutronix.de,
qais.yousef@arm.com, swood@redhat.com,
valentin.schneider@arm.com, juri.lelli@redhat.com,
vincent.guittot@linaro.org, rostedt@goodmis.org,
bsegall@google.com, mgorman@suse.de, bristot@redhat.com,
vincent.donnefort@arm.com
Subject: Re: [PATCH 0/9] sched: Migrate disable support
Date: Fri, 25 Sep 2020 12:10:30 +0200 [thread overview]
Message-ID: <20200925101030.GA2594@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <6f55a303-0e5c-8e84-65d3-798b589a5d75@arm.com>
On Fri, Sep 25, 2020 at 11:12:09AM +0200, Dietmar Eggemann wrote:
> I get this when running 6 (periodic) RT50 tasks with CPU hp stress on my
> 6 CPU JUNO board (!CONFIG_PREEMPT_RT).
>
> [ 55.490263] ------------[ cut here ]------------
> [ 55.505261] Modules linked in:
> [ 55.508322] CPU: 3 PID: 24 Comm: migration/3 Not tainted
> 5.9.0-rc1-00132-gc096e6406c50-dirty #90
> [ 55.517119] Hardware name: ARM Juno development board (r0) (DT)
> [ 55.523058] Stopper: multi_cpu_stop+0x0/0x170 <- 0x0
> [ 55.528029] pstate: 20000085 (nzCv daIf -PAN -UAO BTYPE=--)
> [ 55.533612] pc : sched_cpu_dying+0x124/0x130
> [ 55.537887] lr : sched_cpu_dying+0xd8/0x130
> [ 55.542071] sp : ffff800011f0bca0
> [ 55.545385] x29: ffff800011f0bca0 x28: 0000000000000002
> [ 55.550703] x27: 0000000000000000 x26: 0000000000000060
> [ 55.556022] x25: 0000000000000000 x24: 0000000000000001
> [ 55.561340] x23: 0000000000000000 x22: 0000000000000003
> [ 55.566659] x21: 0000000000000080 x20: 0000000000000003
> [ 55.571977] x19: ffff00097ef9e1c0 x18: 0000000000000010
> [ 55.577295] x17: 0000000000000000 x16: 0000000000000000
> [ 55.582613] x15: 0000000000000000 x14: 000000000000015c
> [ 55.587932] x13: 0000000000000000 x12: 00000000000006f1
> [ 55.593250] x11: 0000000000000080 x10: 0000000000000000
> [ 55.598567] x9 : 0000000000000003 x8 : ffff0009743f5900
> [ 55.603886] x7 : 0000000000000003 x6 : 0000000000000000
> [ 55.609204] x5 : 0000000000000001 x4 : 0000000000000002
> [ 55.614521] x3 : 0000000000000000 x2 : 0000000000000013
> [ 55.619839] x1 : 0000000000000008 x0 : 0000000000000003
> [ 55.625158] Call trace:
> [ 55.627607] sched_cpu_dying+0x124/0x130
> [ 55.631535] cpuhp_invoke_callback+0x88/0x210
> [ 55.635897] take_cpu_down+0x7c/0xd8
> [ 55.639475] multi_cpu_stop+0xac/0x170
> [ 55.643227] cpu_stopper_thread+0x98/0x130
> [ 55.647327] smpboot_thread_fn+0x1c4/0x280
> [ 55.651427] kthread+0x140/0x160
> [ 55.654658] ret_from_fork+0x10/0x34
> [ 55.658239] Code: f000e1c1 913fc021 1400034a 17ffffde (d4210000)
> [ 55.664342] ---[ end trace c5b8988b7b701e56 ]---
> [ 55.668963] note: migration/3[24] exited with preempt_count 3
>
> 7309 int sched_cpu_dying(unsigned int cpu)
> ...
> BUG_ON(rq->nr_running != 1 || rq_has_pinned_tasks(rq));
> ...
>
> rq->nr_running is always 2 here in this cases.
>
> balance_hotplug_wait and sched_cpu_wait_empty run in cpuhp/X (CFS)
> whereas sched_cpu_dying in migration/X ?
takedown_cpu() has:
kthread_park(per_cpu_ptr(&cpuhp_state, cpu)->thread);
before calling:
err = stop_machine_cpuslocked(take_cpu_down, NULL, cpumask_of(cpu));
So when we get to sched_cpu_dying(), the only task that _should_ still
be there is migration/X.
Do you have any idea what thread, other than migration/X, is still
active on that CPU? per sched_cpu_wait_empty() we should've pushed out
all userspace tasks, and the cpu hotplug machinery should've put all the
per-cpu kthreads to sleep at this point.
next prev parent reply other threads:[~2020-09-25 10:10 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 16:35 [PATCH 0/9] sched: Migrate disable support Peter Zijlstra
2020-09-21 16:35 ` [PATCH 1/9] stop_machine: Add function and caller debug info Peter Zijlstra
2020-09-21 16:35 ` [PATCH 2/9] sched: Fix balance_callback() Peter Zijlstra
2020-09-23 14:08 ` Thomas Gleixner
2020-09-21 16:36 ` [PATCH 3/9] sched/hotplug: Ensure only per-cpu kthreads run during hotplug Peter Zijlstra
2020-09-25 16:38 ` Dietmar Eggemann
2020-10-02 14:20 ` Peter Zijlstra
2020-09-21 16:36 ` [PATCH 4/9] sched/core: Wait for tasks being pushed away on hotplug Peter Zijlstra
2020-09-21 16:36 ` [PATCH 5/9] sched/hotplug: Consolidate task migration on CPU unplug Peter Zijlstra
2020-10-01 17:12 ` Vincent Donnefort
2020-10-02 14:17 ` Peter Zijlstra
2020-09-21 16:36 ` [PATCH 6/9] sched: Massage set_cpus_allowed Peter Zijlstra
2020-09-23 14:07 ` Thomas Gleixner
2020-09-21 16:36 ` [PATCH 7/9] sched: Add migrate_disable() Peter Zijlstra
2020-09-21 19:16 ` Thomas Gleixner
2020-09-21 20:42 ` Daniel Bristot de Oliveira
2020-09-23 8:31 ` Thomas Gleixner
2020-09-23 10:51 ` Daniel Bristot de Oliveira
2020-09-23 17:08 ` peterz
2020-09-23 17:54 ` Daniel Bristot de Oliveira
2020-09-23 7:48 ` peterz
2020-09-24 11:53 ` Valentin Schneider
2020-09-24 12:29 ` Peter Zijlstra
2020-09-24 12:33 ` Valentin Schneider
2020-09-24 12:35 ` Peter Zijlstra
2020-09-25 16:50 ` Sebastian Andrzej Siewior
2020-10-02 14:21 ` Peter Zijlstra
2020-10-02 14:36 ` Sebastian Andrzej Siewior
2020-09-21 16:36 ` [PATCH 8/9] sched: Fix migrate_disable() vs set_cpus_allowed_ptr() Peter Zijlstra
2020-09-24 19:59 ` Valentin Schneider
2020-09-25 8:43 ` Peter Zijlstra
2020-09-25 10:07 ` Valentin Schneider
2020-09-25 9:05 ` Peter Zijlstra
2020-09-25 9:56 ` Peter Zijlstra
2020-09-25 10:09 ` Valentin Schneider
2020-09-21 16:36 ` [PATCH 9/9] sched/core: Make migrate disable and CPU hotplug cooperative Peter Zijlstra
2020-09-25 9:12 ` [PATCH 0/9] sched: Migrate disable support Dietmar Eggemann
2020-09-25 10:10 ` Peter Zijlstra [this message]
2020-09-25 11:58 ` Dietmar Eggemann
2020-09-25 12:19 ` Valentin Schneider
2020-09-25 17:49 ` Valentin Schneider
2020-09-29 9:15 ` Dietmar Eggemann
2020-09-25 18:17 ` Sebastian Andrzej Siewior
2020-09-25 19:32 ` Valentin Schneider
2020-10-02 14:30 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200925101030.GA2594@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bigeasy@linutronix.de \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=qais.yousef@arm.com \
--cc=rostedt@goodmis.org \
--cc=swood@redhat.com \
--cc=tglx@linutronix.de \
--cc=valentin.schneider@arm.com \
--cc=vincent.donnefort@arm.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).