From: Kees Cook <keescook@chromium.org>
To: Shuah Khan <skhan@linuxfoundation.org>
Cc: Shuah Khan <shuah@kernel.org>,
Naresh Kamboju <naresh.kamboju@linaro.org>,
Hangbin Liu <liuhangbin@gmail.com>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org,
open list <linux-kernel@vger.kernel.org>,
Tim.Bird@sony.com, lkft-triage@lists.linaro.org,
Anders Roxell <anders.roxell@linaro.org>,
Justin Cook <justin.cook@linaro.org>,
Linux-Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: [PATCHv5 kselftest next] selftests/run_kselftest.sh: make each test individually selectable
Date: Fri, 25 Sep 2020 16:46:45 -0700 [thread overview]
Message-ID: <202009251646.43B045E0@keescook> (raw)
In-Reply-To: <f375a87d-7ba3-f97f-b39a-06b61f80c552@linuxfoundation.org>
On Fri, Sep 25, 2020 at 05:06:02PM -0600, Shuah Khan wrote:
> On 9/25/20 3:16 PM, Kees Cook wrote:
> > On Fri, Sep 25, 2020 at 01:51:53PM +0530, Naresh Kamboju wrote:
> > > On Mon, 14 Sep 2020 at 07:53, Hangbin Liu <liuhangbin@gmail.com> wrote:
> > > >
> > > > Currently, after generating run_kselftest.sh, there is no way to choose
> > > > which test we could run. All the tests are listed together and we have
> > > > to run all every time. This patch enhanced the run_kselftest.sh to make
> > > > the tests individually selectable. e.g.
> > > >
> > > > $ ./run_kselftest.sh -t "bpf size timers"
> > >
> > > My test run break on linux next
> > >
> > > ./run_kselftest.sh: line 1331: syntax error near unexpected token `)'
> > > ./run_kselftest.sh: line 1331: `-e -s | --summary )
> > > logfile=$BASE_DIR/output.log; cat /dev/null > $logfile; shift ;;'
> >
> > Yes, please revert this patch. The resulting script is completely
> > trashed:
> >
>
> Thank you both. Now reverted.
I've sent an alternative that I think should do nicely. It will work
well with LAVA as well.
--
Kees Cook
next prev parent reply other threads:[~2020-09-25 23:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200914021758.420874-1-liuhangbin@gmail.com/>
2020-09-14 2:22 ` [PATCHv5 kselftest next] selftests/run_kselftest.sh: make each test individually selectable Hangbin Liu
2020-09-25 8:21 ` Naresh Kamboju
2020-09-25 21:16 ` Kees Cook
2020-09-25 22:37 ` Shuah Khan
2020-09-25 23:06 ` Shuah Khan
2020-09-25 23:46 ` Kees Cook [this message]
2020-09-27 1:53 ` Hangbin Liu
2020-09-28 20:06 ` Kees Cook
2020-09-29 1:27 ` Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202009251646.43B045E0@keescook \
--to=keescook@chromium.org \
--cc=Tim.Bird@sony.com \
--cc=anders.roxell@linaro.org \
--cc=corbet@lwn.net \
--cc=justin.cook@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=lkft-triage@lists.linaro.org \
--cc=naresh.kamboju@linaro.org \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).