linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: David Laight <David.Laight@aculab.com>
Cc: 'Joe Perches' <joe@perches.com>,
	Bartosz Golaszewski <brgl@bgdev.pl>,
	Linus Walleij <linus.walleij@linaro.org>,
	Jonathan Corbet <corbet@lwn.net>,
	Kent Gibson <warthog618@gmail.com>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	linux-doc <linux-doc@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH v2 1/9] lib: string_helpers: provide kfree_strarray()
Date: Tue, 29 Sep 2020 11:49:12 +0300	[thread overview]
Message-ID: <20200929084912.GZ3956970@smile.fi.intel.com> (raw)
In-Reply-To: <3ba6779e11684ec8bc32638aa67ab952@AcuMS.aculab.com>

On Tue, Sep 29, 2020 at 08:10:10AM +0000, David Laight wrote:
> From: Joe Perches
> > Sent: 28 September 2020 17:07
> > 
> > On Mon, 2020-09-28 at 18:02 +0200, Bartosz Golaszewski wrote:
> > > On Mon, Sep 28, 2020 at 5:59 PM Joe Perches <joe@perches.com> wrote:
> > > > On Mon, 2020-09-28 at 12:41 +0200, Bartosz Golaszewski wrote:
> > > > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > > > >
> > > > > There's a common pattern of dynamically allocating an array of char
> > > > > pointers and then also dynamically allocating each string in this
> > > > > array. Provide a helper for freeing such a string array with one call.
> > > >
> > > > Isn't this also common for things like ring buffers?
> > > > Why limit this to char *[]?
> > > >
> > >
> > > I don't want to add APIs nobody is using. What do you suggest?
> > 
> > Change the argument to void** and call it
> > 
> > void kfree_array(void **array, int count);
> 
> Does help, void doesn't work that way.

Actually good catch. void * and void ** have a big difference in the implicit
casting behaviour. I was stumbled over this while playing with some
experimental stuff locally.

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2020-09-29  8:49 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-28 10:41 [PATCH v2 0/9] gpio: mockup: refactoring + documentation Bartosz Golaszewski
2020-09-28 10:41 ` [PATCH v2 1/9] lib: string_helpers: provide kfree_strarray() Bartosz Golaszewski
2020-09-28 12:55   ` Andy Shevchenko
2020-09-28 13:04     ` Bartosz Golaszewski
2020-09-28 13:56       ` Andy Shevchenko
2020-09-28 15:59   ` Joe Perches
2020-09-28 16:02     ` Bartosz Golaszewski
2020-09-28 16:06       ` Joe Perches
2020-09-28 16:25         ` Andy Shevchenko
2020-09-29  8:10         ` David Laight
2020-09-29  8:49           ` Andy Shevchenko [this message]
2020-09-29  9:42             ` Bartosz Golaszewski
2020-09-28 10:41 ` [PATCH v2 2/9] Documentation: gpio: add documentation for gpio-mockup Bartosz Golaszewski
2020-09-28 10:41 ` [PATCH v2 3/9] gpio: mockup: drop unneeded includes Bartosz Golaszewski
2020-09-28 10:41 ` [PATCH v2 4/9] gpio: mockup: use KBUILD_MODNAME Bartosz Golaszewski
2020-09-28 10:41 ` [PATCH v2 5/9] gpio: mockup: use pr_fmt() Bartosz Golaszewski
2020-09-28 10:41 ` [PATCH v2 6/9] gpio: mockup: remove unneeded return statement Bartosz Golaszewski
2020-09-28 10:41 ` [PATCH v2 7/9] gpio: mockup: pass the chip label as device property Bartosz Golaszewski
2020-09-28 13:00   ` Andy Shevchenko
2020-09-28 13:13     ` Bartosz Golaszewski
2020-09-28 14:00       ` Andy Shevchenko
2020-09-28 14:52         ` Bartosz Golaszewski
2020-09-28 16:24           ` Andy Shevchenko
2020-09-28 10:41 ` [PATCH v2 8/9] gpio: mockup: use the generic 'gpio-line-names' property Bartosz Golaszewski
2020-09-28 13:01   ` Andy Shevchenko
2020-09-28 10:41 ` [PATCH v2 9/9] gpio: mockup: refactor the module init function Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200929084912.GZ3956970@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=David.Laight@aculab.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=brgl@bgdev.pl \
    --cc=corbet@lwn.net \
    --cc=joe@perches.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=warthog618@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).