From: Rob Herring <robh@kernel.org>
To: kholk11@gmail.com
Cc: bjorn.andersson@linaro.org, agross@kernel.org,
georgi.djakov@linaro.org, marijns95@gmail.com,
konradybcio@gmail.com, martin.botka1@gmail.com,
linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org,
devicetree@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] dt-bindings: interconnect: Add bindings for Qualcomm SDM660 NoC
Date: Tue, 29 Sep 2020 09:47:16 -0500 [thread overview]
Message-ID: <20200929144716.GB557822@bogus> (raw)
In-Reply-To: <20200928195853.40084-3-kholk11@gmail.com>
On Mon, Sep 28, 2020 at 09:58:53PM +0200, kholk11@gmail.com wrote:
> From: AngeloGioacchino Del Regno <kholk11@gmail.com>
>
> Add the bindings for the Qualcomm SDM660-class NoC, valid for
> SDM630, SDM636, SDM660 and SDA variants.
>
> Signed-off-by: AngeloGioacchino Del Regno <kholk11@gmail.com>
> ---
> .../bindings/interconnect/qcom,sdm660.yaml | 147 ++++++++++++++++++
> 1 file changed, 147 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/interconnect/qcom,sdm660.yaml
>
> diff --git a/Documentation/devicetree/bindings/interconnect/qcom,sdm660.yaml b/Documentation/devicetree/bindings/interconnect/qcom,sdm660.yaml
> new file mode 100644
> index 000000000000..440e9bc1382a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interconnect/qcom,sdm660.yaml
> @@ -0,0 +1,147 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/interconnect/qcom,sdm660.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm SDM660 Network-On-Chip interconnect
> +
> +maintainers:
> + - Georgi Djakov <georgi.djakov@linaro.org>
> +
> +description: |
> + The Qualcomm SDM660 interconnect providers support adjusting the
> + bandwidth requirements between the various NoC fabrics.
> +
> +properties:
> + reg:
> + maxItems: 1
> +
> + compatible:
> + enum:
> + - qcom,sdm660-a2noc
> + - qcom,sdm660-bimc
> + - qcom,sdm660-cnoc
> + - qcom,sdm660-gnoc
> + - qcom,sdm660-mnoc
> + - qcom,sdm660-snoc
> +
> + '#interconnect-cells':
> + const: 1
> +
> + clocks:
> + minItems: 1
Looks like 2 is the min?
> + maxItems: 3
> +
> + clock-names:
> + minItems: 1
> + maxItems: 3
> +
> +required:
> + - compatible
> + - reg
> + - '#interconnect-cells'
> + - clock-names
> + - clocks
> +
> +additionalProperties: false
> +
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - qcom,sdm660-mnoc
> + then:
> + properties:
> + clocks:
> + items:
> + - description: Bus Clock.
> + - description: Bus A Clock.
> + - description: CPU-NoC High-performance Bus Clock.
> + clock-names:
> + items:
> + - const: bus
> + - const: bus_a
> + - const: iface
Given both cases are the same except the 3rd clock, all this can be
moved to the main section. Then here you just need to restrict things
to 2 or 3 clocks.
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - qcom,sdm660-a2noc
> + - qcom,sdm660-bimc
> + - qcom,sdm660-cnoc
> + - qcom,sdm660-gnoc
> + - qcom,sdm660-snoc
> + then:
> + properties:
> + clocks:
> + items:
> + - description: Bus Clock.
> + - description: Bus A Clock.
> + clock-names:
> + items:
> + - const: bus
> + - const: bus_a
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/qcom,rpmcc.h>
> + #include <dt-bindings/clock/qcom,mmcc-sdm660.h>
> +
> + bimc: interconnect@1008000 {
> + compatible = "qcom,sdm660-bimc";
> + reg = <0x01008000 0x78000>;
> + #interconnect-cells = <1>;
> + clock-names = "bus", "bus_a";
> + clocks = <&rpmcc RPM_SMD_BIMC_CLK>,
> + <&rpmcc RPM_SMD_BIMC_A_CLK>;
> + };
> +
> + cnoc: interconnect@1500000 {
> + compatible = "qcom,sdm660-cnoc";
> + reg = <0x01500000 0x10000>;
> + #interconnect-cells = <1>;
> + clock-names = "bus", "bus_a";
> + clocks = <&rpmcc RPM_SMD_CNOC_CLK>,
> + <&rpmcc RPM_SMD_CNOC_A_CLK>;
> + };
> +
> + snoc: interconnect@1626000 {
> + compatible = "qcom,sdm660-snoc";
> + reg = <0x01626000 0x7090>;
> + #interconnect-cells = <1>;
> + clock-names = "bus", "bus_a";
> + clocks = <&rpmcc RPM_SMD_SNOC_CLK>,
> + <&rpmcc RPM_SMD_SNOC_A_CLK>;
> + };
> +
> + a2noc: interconnect@1704000 {
> + compatible = "qcom,sdm660-a2noc";
> + reg = <0x01704000 0xc100>;
> + #interconnect-cells = <1>;
> + clock-names = "bus", "bus_a";
> + clocks = <&rpmcc RPM_SMD_AGGR2_NOC_CLK>,
> + <&rpmcc RPM_SMD_AGGR2_NOC_A_CLK>;
> + };
> +
> + mnoc: interconnect@1745000 {
> + compatible = "qcom,sdm660-mnoc";
> + reg = <0x01745000 0xa010>;
> + #interconnect-cells = <1>;
> + clock-names = "bus", "bus_a", "iface";
> + clocks = <&rpmcc RPM_SMD_MMSSNOC_AXI_CLK>,
> + <&rpmcc RPM_SMD_MMSSNOC_AXI_CLK_A>,
> + <&mmcc AHB_CLK_SRC>;
> + };
> +
> + gnoc: interconnect@17900000 {
> + compatible = "qcom,sdm660-gnoc";
> + reg = <0x17900000 0xe000>;
> + #interconnect-cells = <1>;
> + clock-names = "bus", "bus_a";
> + clocks = <&xo_board>, <&xo_board>;
> + };
> --
> 2.28.0
>
prev parent reply other threads:[~2020-09-29 14:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 19:58 [PATCH v2 0/2] Add SDM630/636/660 interconnect driver kholk11
2020-09-28 19:58 ` [PATCH v2 1/2] interconnect: qcom: Add SDM660 interconnect provider driver kholk11
2020-10-06 18:19 ` Rob Herring
2020-09-28 19:58 ` [PATCH v2 2/2] dt-bindings: interconnect: Add bindings for Qualcomm SDM660 NoC kholk11
2020-09-29 14:43 ` Rob Herring
2020-09-29 14:47 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200929144716.GB557822@bogus \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=georgi.djakov@linaro.org \
--cc=kholk11@gmail.com \
--cc=konradybcio@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=marijns95@gmail.com \
--cc=martin.botka1@gmail.com \
--cc=phone-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).