linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: gregkh@linuxfoundation.org
Cc: hemantk@codeaurora.org, bbhatt@codeaurora.org,
	linux-arm-msm@vger.kernel.org, jhugo@codeaurora.org,
	linux-kernel@vger.kernel.org,
	Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Subject: [PATCH v3 08/19] bus: mhi: core: Introduce counters to track MHI device state transitions
Date: Tue, 29 Sep 2020 23:22:07 +0530	[thread overview]
Message-ID: <20200929175218.8178-9-manivannan.sadhasivam@linaro.org> (raw)
In-Reply-To: <20200929175218.8178-1-manivannan.sadhasivam@linaro.org>

From: Bhaumik Bhatt <bbhatt@codeaurora.org>

Use counters to track MHI device state transitions such as those
to M0, M2, or M3 states. This can help in better debug, allowing
the user to see the number of transitions to a certain MHI state
when queried using debugfs entries or via other mechanisms.

Signed-off-by: Bhaumik Bhatt <bbhatt@codeaurora.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
 drivers/bus/mhi/core/pm.c | 4 ++++
 include/linux/mhi.h       | 2 ++
 2 files changed, 6 insertions(+)

diff --git a/drivers/bus/mhi/core/pm.c b/drivers/bus/mhi/core/pm.c
index 27bb471c8f4e..ce4d969818b4 100644
--- a/drivers/bus/mhi/core/pm.c
+++ b/drivers/bus/mhi/core/pm.c
@@ -256,6 +256,7 @@ int mhi_pm_m0_transition(struct mhi_controller *mhi_cntrl)
 		dev_err(dev, "Unable to transition to M0 state\n");
 		return -EIO;
 	}
+	mhi_cntrl->M0++;
 
 	/* Wake up the device */
 	read_lock_bh(&mhi_cntrl->pm_lock);
@@ -326,6 +327,8 @@ void mhi_pm_m1_transition(struct mhi_controller *mhi_cntrl)
 		mhi_cntrl->dev_state = MHI_STATE_M2;
 
 		write_unlock_irq(&mhi_cntrl->pm_lock);
+
+		mhi_cntrl->M2++;
 		wake_up_all(&mhi_cntrl->state_event);
 
 		/* If there are any pending resources, exit M2 immediately */
@@ -362,6 +365,7 @@ int mhi_pm_m3_transition(struct mhi_controller *mhi_cntrl)
 		return -EIO;
 	}
 
+	mhi_cntrl->M3++;
 	wake_up_all(&mhi_cntrl->state_event);
 
 	return 0;
diff --git a/include/linux/mhi.h b/include/linux/mhi.h
index bb337d163dda..c56b4447a4e9 100644
--- a/include/linux/mhi.h
+++ b/include/linux/mhi.h
@@ -328,6 +328,7 @@ struct mhi_controller_config {
  * @dev_state: MHI device state
  * @dev_wake: Device wakeup count
  * @pending_pkts: Pending packets for the controller
+ * @M0, M2, M3: Counters to track number of device MHI state changes
  * @transition_list: List of MHI state transitions
  * @transition_lock: Lock for protecting MHI state transition list
  * @wlock: Lock for protecting device wakeup
@@ -407,6 +408,7 @@ struct mhi_controller {
 	enum mhi_state dev_state;
 	atomic_t dev_wake;
 	atomic_t pending_pkts;
+	u32 M0, M2, M3;
 	struct list_head transition_list;
 	spinlock_t transition_lock;
 	spinlock_t wlock;
-- 
2.17.1


  parent reply	other threads:[~2020-09-29 17:53 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-29 17:51 [PATCH v3 00/19] MHI changes for v5.10 Manivannan Sadhasivam
2020-09-29 17:52 ` [PATCH v3 01/19] bus: mhi: fix doubled words and struct image_info kernel-doc Manivannan Sadhasivam
2020-09-29 17:52 ` [PATCH v3 02/19] bus: mhi: core: Remove double occurrence for mhi_ctrl_ev_task() declaration Manivannan Sadhasivam
2020-09-29 17:52 ` [PATCH v3 03/19] bus: mhi: core: Abort suspends due to outgoing pending packets Manivannan Sadhasivam
2020-09-29 17:52 ` [PATCH v3 04/19] bus: mhi: core: Use helper API to trigger a non-blocking host resume Manivannan Sadhasivam
2020-09-29 17:52 ` [PATCH v3 05/19] bus: mhi: core: Trigger host resume if suspended during mhi_device_get() Manivannan Sadhasivam
2020-09-29 17:52 ` [PATCH v3 06/19] bus: mhi: core: Use generic name field for an MHI device Manivannan Sadhasivam
2020-09-29 17:52 ` [PATCH v3 07/19] bus: mhi: core: Introduce helper function to check device state Manivannan Sadhasivam
2020-09-29 17:52 ` Manivannan Sadhasivam [this message]
2020-09-29 17:52 ` [PATCH v3 09/19] bus: mhi: core: Read and save device hardware information from BHI Manivannan Sadhasivam
2020-09-29 17:52 ` [PATCH v3 10/19] bus: mhi: core: Introduce APIs to allocate and free the MHI controller Manivannan Sadhasivam
2020-09-29 17:52 ` [PATCH v3 11/19] bus: mhi: core: Add const qualifier to MHI config information Manivannan Sadhasivam
2020-09-29 17:52 ` [PATCH v3 12/19] bus: mhi: Remove include of rwlock_types.h Manivannan Sadhasivam
2020-09-29 17:52 ` [PATCH v3 13/19] bus: mhi: Fix entries based on Kconfig coding style Manivannan Sadhasivam
2020-09-29 17:52 ` [PATCH v3 14/19] bus: mhi: core: Introduce debugfs entries for MHI Manivannan Sadhasivam
2020-09-29 17:52 ` [PATCH v3 15/19] bus: mhi: core: Introduce sysfs " Manivannan Sadhasivam
2020-09-29 17:52 ` [PATCH v3 16/19] bus: mhi: core: Allow shared IRQ for event rings Manivannan Sadhasivam
2020-09-29 17:52 ` [PATCH v3 17/19] bus: mhi: Remove unused nr_irqs_req variable Manivannan Sadhasivam
2020-09-29 17:52 ` [PATCH v3 18/19] bus: mhi: core: Fix the building of MHI module Manivannan Sadhasivam
2020-09-29 17:52 ` [PATCH v3 19/19] bus: mhi: debugfs: Print channel context read-pointer Manivannan Sadhasivam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200929175218.8178-9-manivannan.sadhasivam@linaro.org \
    --to=manivannan.sadhasivam@linaro.org \
    --cc=bbhatt@codeaurora.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hemantk@codeaurora.org \
    --cc=jhugo@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).