From: Maxime Ripard <maxime@cerno.tech>
To: "Clément Péron" <peron.clem@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: allwinner: h6: add eMMC voltage property for Beelink GS1
Date: Wed, 30 Sep 2020 12:27:32 +0200 [thread overview]
Message-ID: <20200930102732.zc3vs4vzm3fyt5dc@gilmour.lan> (raw)
In-Reply-To: <20200928150038.97413-1-peron.clem@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1157 bytes --]
Hi,
On Mon, Sep 28, 2020 at 05:00:37PM +0200, Clément Péron wrote:
> VQMMC supply is connected to BLDO2 which provides 1.8V.
>
> Let's reflect this in the device-tree.
This commit log doesn't really explain what is going on though?
> Fixes: 089bee8dd119 ("arm64: dts: allwinner: h6: Introduce Beelink GS1 board")
> Signed-off-by: Clément Péron <peron.clem@gmail.com>
> ---
> arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
> index 049c21718846..3f20d2c9bbbb 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
> @@ -145,6 +145,7 @@ &mmc2 {
> vqmmc-supply = <®_bldo2>;
The Device Tree already expresses that the vqmmc supply is connected to
BLDO2 which provides 1.8V here (together with the reg_bldo2 node).
> non-removable;
> cap-mmc-hw-reset;
> + mmc-hs200-1_8v;
Whereas this indicates that the eMMC supports the HS200 MMC mode at 1.8V
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2020-09-30 10:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 15:00 [PATCH] arm64: dts: allwinner: h6: add eMMC voltage property for Beelink GS1 Clément Péron
2020-09-30 10:27 ` Maxime Ripard [this message]
2020-10-02 15:40 ` Clément Péron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200930102732.zc3vs4vzm3fyt5dc@gilmour.lan \
--to=maxime@cerno.tech \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peron.clem@gmail.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).