From: Ming Lei <ming.lei@redhat.com>
To: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org
Cc: Ming Lei <ming.lei@redhat.com>,
Veronika Kabatova <vkabatov@redhat.com>,
Sagi Grimberg <sagi@grimberg.me>, Tejun Heo <tj@kernel.org>,
Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Bart Van Assche <bvanassche@acm.org>
Subject: [PATCH V7 0/2] percpu_ref & block: reduce memory footprint of percpu_ref in fast path
Date: Thu, 1 Oct 2020 23:48:40 +0800 [thread overview]
Message-ID: <20201001154842.26896-1-ming.lei@redhat.com> (raw)
Hi,
The 1st patch removes memory footprint of percpu_ref in fast path
from 7 words to 2 words, since it is often used in fast path and
embedded in user struct.
The 2nd patch moves .q_usage_counter to 1st cacheline of
'request_queue'.
Simple test on null_blk shows ~2% IOPS boost on one 16cores(two threads
per core) machine, dual socket/numa.
V7:
- add comments about reason for struct split
V6:
- drop the 1st patch which adds percpu_ref_is_initialized() for MD
only, since Christoph doesn't like it
V5:
- fix memory leak on ref->data, only percpu_ref_exit() of patch 2
is modified.
V4:
- rename percpu_ref_inited as percpu_ref_is_initialized
V3:
- fix kernel oops on MD
- add patch for avoiding to use percpu-refcount internal from md
code
- pass Red Hat CKI test which is done by Veronika Kabatova
V2:
- pass 'gfp' to kzalloc() for fixing block/027 failure reported by
kernel test robot
- protect percpu_ref_is_zero() with destroying percpu-refcount by
spin lock
Ming Lei (2):
percpu_ref: reduce memory footprint of percpu_ref in fast path
block: move 'q_usage_counter' into front of 'request_queue'
drivers/infiniband/sw/rdmavt/mr.c | 2 +-
include/linux/blkdev.h | 3 +-
include/linux/percpu-refcount.h | 52 ++++++------
lib/percpu-refcount.c | 131 ++++++++++++++++++++++--------
4 files changed, 125 insertions(+), 63 deletions(-)
Cc: Veronika Kabatova <vkabatov@redhat.com>
Cc: Sagi Grimberg <sagi@grimberg.me>
Cc: Tejun Heo <tj@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Bart Van Assche <bvanassche@acm.org>
--
2.25.2
next reply other threads:[~2020-10-01 15:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-01 15:48 Ming Lei [this message]
2020-10-01 15:48 ` [PATCH V7 1/2] percpu_ref: reduce memory footprint of percpu_ref in fast path Ming Lei
2020-10-01 15:50 ` Tejun Heo
2020-10-01 15:48 ` [PATCH V7 2/2] block: move 'q_usage_counter' into front of 'request_queue' Ming Lei
2020-10-06 7:41 ` [PATCH V7 0/2] percpu_ref & block: reduce memory footprint of percpu_ref in fast path Ming Lei
2020-10-06 13:30 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201001154842.26896-1-ming.lei@redhat.com \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sagi@grimberg.me \
--cc=tj@kernel.org \
--cc=vkabatov@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).