From: Willy Tarreau <w@1wt.eu>
To: Thibaut Sautereau <thibaut.sautereau@clip-os.org>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Kees Cook <keescook@chromium.org>,
netdev@vger.kernel.org, kernel-hardening@lists.openwall.com,
linux-kernel@vger.kernel.org,
Thibaut Sautereau <thibaut.sautereau@ssi.gouv.fr>,
Linus Torvalds <torvalds@linux-foundation.org>,
Emese Revfy <re.emese@gmail.com>
Subject: Re: [PATCH] random32: Restore __latent_entropy attribute on net_rand_state
Date: Fri, 2 Oct 2020 17:22:19 +0200 [thread overview]
Message-ID: <20201002152219.GB3875@1wt.eu> (raw)
In-Reply-To: <20201002151610.24258-1-thibaut.sautereau@clip-os.org>
On Fri, Oct 02, 2020 at 05:16:11PM +0200, Thibaut Sautereau wrote:
> From: Thibaut Sautereau <thibaut.sautereau@ssi.gouv.fr>
>
> Commit f227e3ec3b5c ("random32: update the net random state on interrupt
> and activity") broke compilation and was temporarily fixed by Linus in
> 83bdc7275e62 ("random32: remove net_rand_state from the latent entropy
> gcc plugin") by entirely moving net_rand_state out of the things handled
> by the latent_entropy GCC plugin.
>
> From what I understand when reading the plugin code, using the
> __latent_entropy attribute on a declaration was the wrong part and
> simply keeping the __latent_entropy attribute on the variable definition
> was the correct fix.
Ah thank you, this is what I tried to figure and failed to! Spender
mentioned that a one-liner was all that was needed to fix this but
never responded to my request asking about it.
Willy
next prev parent reply other threads:[~2020-10-02 15:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 15:16 [PATCH] random32: Restore __latent_entropy attribute on net_rand_state Thibaut Sautereau
2020-10-02 15:22 ` Willy Tarreau [this message]
2020-10-06 2:12 ` Kees Cook
2020-10-06 2:28 ` Willy Tarreau
2020-10-06 5:57 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201002152219.GB3875@1wt.eu \
--to=w@1wt.eu \
--cc=davem@davemloft.net \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=re.emese@gmail.com \
--cc=thibaut.sautereau@clip-os.org \
--cc=thibaut.sautereau@ssi.gouv.fr \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).