From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62568C4363D for ; Fri, 2 Oct 2020 19:29:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DB355206DD for ; Fri, 2 Oct 2020 19:29:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="S2pmYheC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388374AbgJBT3z (ORCPT ); Fri, 2 Oct 2020 15:29:55 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:46628 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725991AbgJBT3z (ORCPT ); Fri, 2 Oct 2020 15:29:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601666994; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UUF8r6P20KLuB/qZTy80TaYlmTrYZ31o4GL8SMne1Mc=; b=S2pmYheCScYhbLNh++XN1USyPiXsQjkVnLRSeyuHYKt91spro2kRLkSL1NPHD+2EKj2SyH WzAh8FrAUvvON7BrKfSiKb9oHtyW5kIsASNP6tsrggCYipSxGC7Me3Hnp/uhGlGJKyrgIH eb725075iv6w2MqvybbK4HVlFEI5whc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-52-jZrE_AY5O5OsnuRt6N3Tiw-1; Fri, 02 Oct 2020 15:29:50 -0400 X-MC-Unique: jZrE_AY5O5OsnuRt6N3Tiw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A07508030BE; Fri, 2 Oct 2020 19:29:48 +0000 (UTC) Received: from krava (ovpn-114-211.ams2.redhat.com [10.36.114.211]) by smtp.corp.redhat.com (Postfix) with SMTP id E1F6973677; Fri, 2 Oct 2020 19:29:45 +0000 (UTC) Date: Fri, 2 Oct 2020 21:29:44 +0200 From: Jiri Olsa To: Ian Rogers Cc: Namhyung Kim , Jiri Olsa , Arnaldo Carvalho de Melo , lkml , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Michael Petlan , Stephane Eranian Subject: Re: [PATCHv2 1/9] perf tools: Add build id shell test Message-ID: <20201002192944.GH3999500@krava> References: <20200930171512.3986425-1-jolsa@kernel.org> <20200930171512.3986425-2-jolsa@kernel.org> <20201001190530.GD3999500@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 02, 2020 at 10:34:51AM -0700, Ian Rogers wrote: SNIP > > > + > > > LIBJVMTI = libperf-jvmti.so > > > > > > ifndef NO_JVMTI > > > @@ -756,6 +763,13 @@ $(OUTPUT)perf-read-vdsox32: perf-read-vdso.c util/find-map.c > > > $(QUIET_CC)$(CC) -mx32 $(filter -static,$(LDFLAGS)) -Wall -Werror -o $@ perf-read-vdso.c > > > endif > > > > > > +ifndef NO_BUILDID_EX > > > +$(OUTPUT)buildid-ex-sha1: > > > + $(QUIET_LINK)echo 'int main(void) { return 0; }' | $(CC) -Wl,--build-id=sha1 -o $@ -x c - > > > +$(OUTPUT)buildid-ex-md5: > > > + $(QUIET_LINK)echo 'int main(void) { return 0; }' | $(CC) -Wl,--build-id=md5 -o $@ -x c - > > > +endif > > > > Can we just build them in the test shell script instead? it would solve the build-directory/install-directory lookup search.. but it'd need to do detect compiler and depend on it as Ian said do you have some other reason to compile it in test? thanks, jirka > > > > Thanks > > Namhyung > > That'd mean perf test having a dependency on a compiler :-/ That said > there are some existing dependencies for BPF compilers. > > Thanks, > Ian SNIP