From: David Miller <davem@davemloft.net>
To: colin.king@canonical.com
Cc: andrew@lunn.ch, hkallweit1@gmail.com, kuba@kernel.org,
dmurphy@ti.com, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] net: phy: dp83869: fix unsigned comparisons against less than zero values
Date: Sat, 03 Oct 2020 17:09:14 -0700 (PDT) [thread overview]
Message-ID: <20201003.170914.694797784124863729.davem@davemloft.net> (raw)
In-Reply-To: <20201002165422.94328-1-colin.king@canonical.com>
From: Colin King <colin.king@canonical.com>
Date: Fri, 2 Oct 2020 17:54:22 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently the comparisons of u16 integers value and sopass_val with
> less than zero for error checking is always false because the values
> are unsigned. Fix this by making these variables int. This does not
> affect the shift and mask operations performed on these variables
>
> Addresses-Coverity: ("Unsigned compared against zero")
> Fixes: 49fc23018ec6 ("net: phy: dp83869: support Wake on LAN")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thank you.
prev parent reply other threads:[~2020-10-04 0:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 16:54 [PATCH][next] net: phy: dp83869: fix unsigned comparisons against less than zero values Colin King
2020-10-02 17:26 ` Dan Murphy
2020-10-02 17:39 ` Andrew Lunn
2020-10-06 18:26 ` Dan Carpenter
2020-10-04 0:09 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201003.170914.694797784124863729.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=colin.king@canonical.com \
--cc=dmurphy@ti.com \
--cc=hkallweit1@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).