From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Vasily Gorbik <gor@linux.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Masami Hiramatsu <mhiramat@kernel.org>,
David Laight <David.Laight@aculab.com>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Miroslav Benes <mbenes@suse.cz>,
Alexandre Chartre <alexandre.chartre@oracle.com>,
Julien Thierry <jthierry@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v4 4/4] objtool: fix x86 orc generation on big endian cross compiles
Date: Mon, 5 Oct 2020 09:03:28 -0500 [thread overview]
Message-ID: <20201005140328.hpbpkfpx3hmpuapt@treble> (raw)
In-Reply-To: <patch-4.thread-a8def4.git-a8def4f04016.your-ad-here.call-01601818410-ext-7687@work.hours>
On Sun, Oct 04, 2020 at 04:30:54PM +0200, Vasily Gorbik wrote:
> @@ -77,8 +78,9 @@ static int get_alt_entry(struct elf *elf, struct special_entry *entry,
> if (entry->feature) {
> unsigned short feature;
>
> - feature = *(unsigned short *)(sec->data->d_buf + offset +
> - entry->feature);
> + feature = bswap_if_needed(*(unsigned short *)(sec->data->d_buf +
> + offset +
> + entry->feature));
> arch_handle_alternative(feature, alt);
> }
> ---
> arch/x86/include/asm/orc_types.h | 10 +++++
> tools/arch/x86/include/asm/orc_types.h | 10 +++++
> .../arch/x86/include/arch_endianness.h | 9 +++++
> tools/objtool/check.c | 5 ++-
> tools/objtool/endianness.h | 38 +++++++++++++++++++
> tools/objtool/orc_dump.c | 5 ++-
> tools/objtool/orc_gen.c | 3 ++
> tools/objtool/special.c | 6 ++-
> 8 files changed, 80 insertions(+), 6 deletions(-)
> create mode 100644 tools/objtool/arch/x86/include/arch_endianness.h
> create mode 100644 tools/objtool/endianness.h
>
> diff --git a/arch/x86/include/asm/orc_types.h b/arch/x86/include/asm/orc_types.h
> index fdbffec4cfde..5a2baf28a1dc 100644
This patch is misformatted. Almost like it was concatenated with
itself?
--
Josh
next prev parent reply other threads:[~2020-10-05 14:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 22:17 [RFC PATCH v3 0/4] objtool and cross compilation Vasily Gorbik
2020-09-30 22:17 ` [RFC PATCH v3 1/4] objtool: allow nested externs to enable BUILD_BUG() Vasily Gorbik
2020-09-30 22:17 ` [RFC PATCH v3 2/4] objtool: x86 instruction decoder and big endian cross compiles Vasily Gorbik
2020-10-02 15:18 ` Josh Poimboeuf
2020-10-05 3:41 ` Masami Hiramatsu
2020-09-30 22:17 ` [RFC PATCH v3 3/4] objtool: correct rebuilding of reloc sections Vasily Gorbik
2020-09-30 22:17 ` [RFC PATCH v3 4/4] objtool: fix x86 orc generation on big endian cross compiles Vasily Gorbik
2020-10-02 16:01 ` Josh Poimboeuf
2020-10-04 14:30 ` [RFC PATCH v4 0/4] objtool and cross compilation Vasily Gorbik
2020-10-04 14:30 ` [RFC PATCH v4 1/4] objtool: allow nested externs to enable BUILD_BUG() Vasily Gorbik
2020-10-04 14:30 ` [RFC PATCH v4 2/4] x86/insn: instruction decoder and big endian cross compiles Vasily Gorbik
2020-10-04 14:30 ` [RFC PATCH v4 3/4] objtool: correct rebuilding of reloc sections Vasily Gorbik
2020-10-04 14:30 ` [RFC PATCH v4 4/4] objtool: fix x86 orc generation on big endian cross compiles Vasily Gorbik
2020-10-05 14:03 ` Josh Poimboeuf [this message]
2020-10-05 15:50 ` [RFC PATCH RESEND v4 0/4] objtool and cross compilation Vasily Gorbik
2020-10-05 15:50 ` [RFC PATCH RESEND v4 1/4] objtool: allow nested externs to enable BUILD_BUG() Vasily Gorbik
2020-10-05 15:50 ` [RFC PATCH RESEND v4 2/4] x86/insn: instruction decoder and big endian cross compiles Vasily Gorbik
2020-10-05 15:50 ` [RFC PATCH RESEND v4 3/4] objtool: correct rebuilding of reloc sections Vasily Gorbik
2020-10-05 15:50 ` [RFC PATCH RESEND v4 4/4] objtool: fix x86 orc generation on big endian cross compiles Vasily Gorbik
2020-10-05 15:50 ` [PATCH v2] objtool: avoid ../ headers includes and name clashes Vasily Gorbik
2020-10-05 15:56 ` [RFC PATCH v4 4/4] objtool: fix x86 orc generation on big endian cross compiles Vasily Gorbik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201005140328.hpbpkfpx3hmpuapt@treble \
--to=jpoimboe@redhat.com \
--cc=David.Laight@aculab.com \
--cc=alexandre.chartre@oracle.com \
--cc=bp@alien8.de \
--cc=gor@linux.ibm.com \
--cc=hpa@zytor.com \
--cc=jthierry@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).