linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Weiner <hannes@cmpxchg.org>
To: Roman Gushchin <guro@fb.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Shakeel Butt <shakeelb@google.com>,
	Michal Hocko <mhocko@kernel.org>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	kernel-team@fb.com
Subject: Re: [PATCH v5 3/4] mm: introduce page memcg flags
Date: Mon, 5 Oct 2020 10:57:49 -0400	[thread overview]
Message-ID: <20201005145749.GA3390@cmpxchg.org> (raw)
In-Reply-To: <20201002172559.4000748-4-guro@fb.com>

On Fri, Oct 02, 2020 at 10:25:58AM -0700, Roman Gushchin wrote:
> The lowest bit in page->memcg_data is used to distinguish between
> struct memory_cgroup pointer and a pointer to a objcgs array.
> All checks and modifications of this bit are open-coded.
> 
> Let's formalize it using page memcg flags, defined in enum
> page_memcg_data_flags.
> 
> Additional flags might be added later.
> 
> Signed-off-by: Roman Gushchin <guro@fb.com>
> Reviewed-by: Shakeel Butt <shakeelb@google.com>

Acked-by: Johannes Weiner <hannes@cmpxchg.org>

  reply	other threads:[~2020-10-05 14:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-02 17:25 [PATCH v5 0/4] mm: allow mapping accounted kernel pages to userspace Roman Gushchin
2020-10-02 17:25 ` [PATCH v5 1/4] mm: memcontrol: use helpers to read page's memcg data Roman Gushchin
2020-10-05 15:12   ` Shakeel Butt
2020-10-14 14:37   ` Michal Hocko
2020-10-02 17:25 ` [PATCH v5 2/4] mm: memcontrol/slab: use helpers to access slab page's memcg_data Roman Gushchin
2020-10-05 15:13   ` Shakeel Butt
2020-10-02 17:25 ` [PATCH v5 3/4] mm: introduce page memcg flags Roman Gushchin
2020-10-05 14:57   ` Johannes Weiner [this message]
2020-10-14 14:37   ` Michal Hocko
2020-10-02 17:25 ` [PATCH v5 4/4] mm: convert page kmemcg type to a page memcg flag Roman Gushchin
2020-10-05 15:18   ` Shakeel Butt
2020-10-14 14:40   ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201005145749.GA3390@cmpxchg.org \
    --to=hannes@cmpxchg.org \
    --cc=akpm@linux-foundation.org \
    --cc=guro@fb.com \
    --cc=kernel-team@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=shakeelb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).