From: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: x86@kernel.org, Borislav Petkov <bp@suse.de>,
Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Tony Luck <tony.luck@intel.com>, Len Brown <len.brown@intel.com>,
"Ravi V. Shankar" <ravi.v.shankar@intel.com>,
linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>,
Dave Hansen <dave.hansen@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Subject: Re: [PATCH 4/4] x86/cpu/topology: Implement the CPU type sysfs interface
Date: Mon, 5 Oct 2020 18:05:36 -0700 [thread overview]
Message-ID: <20201006010536.GE6041@ranerica-svr.sc.intel.com> (raw)
In-Reply-To: <20201003085506.GB114893@kroah.com>
On Sat, Oct 03, 2020 at 10:55:06AM +0200, Greg Kroah-Hartman wrote:
> On Fri, Oct 02, 2020 at 06:17:45PM -0700, Ricardo Neri wrote:
> > Recent Intel processors combine CPUs with different types of micro-
> > architecture in the same package. There may be applications interested in
> > knowing the type topology of the system. For instance, it can be used to
> > to determine which subsets of CPUs share a common feature.
> >
> > Implement cpu_type sysfs interfaces for Intel processors.
> >
> > For example, in a system with four Intel Atom CPUs and one Intel Core CPU,
> > these entries look as below. In this example, the native model IDs for
> > both types of CPUs are 0:
> >
> > user@host:~$: ls /sys/devices/system/cpu/types
> > intel_atom_0 intel_core_0
> >
> > user@host:~$ ls /sys/devices/system/cpu/types/intel_atom_0
> > cpulist cpumap
> >
> > user@host:~$ ls /sys/devices/system/cpu/types/intel_core_0
> > cpulist cpumap
> >
> > user@host:~$ cat /sys/devices/system/cpu/types/intel_atom/cpumap
> > 0f
> >
> > user@host:~$ cat /sys/devices/system/cpu/types/intel_atom/cpulist
> > 0-3
> >
> > user@nost:~$ cat /sys/devices/system/cpu/types/intel_core/cpumap
> > 10
> >
> > user@host:~$ cat /sys/devices/system/cpu/types/intel_core/cpulist
> > 4
>
> You used the same changelog text here as you did in patch 1/4, why?
In both changesets, if merged, somebody could conveniently do git show
on either commit quickly see the result intent of the changeset.
Would it make it better if in patch 1/4 I put an hypothetical generic
example?
Something like:
user@host:~$: ls /sys/devices/system/cpu/types
<arch>_<type_a> <arch><type_b>
Thanks and BR,
Ricardo
next prev parent reply other threads:[~2020-10-06 1:03 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-03 1:17 [PATCH 0/4] drivers core: Introduce CPU type sysfs interface Ricardo Neri
2020-10-03 1:17 ` [PATCH 1/4] " Ricardo Neri
2020-10-03 3:27 ` Randy Dunlap
2020-10-06 1:15 ` Ricardo Neri
2020-10-10 3:14 ` Randy Dunlap
2020-10-03 8:53 ` Greg Kroah-Hartman
2020-10-03 11:05 ` Greg Kroah-Hartman
2020-10-06 1:08 ` Ricardo Neri
2020-10-06 0:57 ` Ricardo Neri
2020-10-06 7:37 ` Greg Kroah-Hartman
2020-10-07 3:14 ` Ricardo Neri
2020-10-07 5:15 ` Greg Kroah-Hartman
2020-10-08 3:34 ` Ricardo Neri
2020-11-12 6:19 ` Brice Goglin
2020-11-12 6:42 ` Greg Kroah-Hartman
2020-11-12 9:10 ` Brice Goglin
2020-11-12 10:49 ` Greg Kroah-Hartman
2020-11-17 15:55 ` Brice Goglin
2020-11-18 10:45 ` Brice Goglin
2020-11-18 10:57 ` Greg Kroah-Hartman
[not found] ` <38f290d2-4c3a-d1b0-f3cc-a0897ea10abd@gmail.com>
2020-11-12 11:34 ` Greg Kroah-Hartman
2020-11-19 8:25 ` Fox Chen
2020-10-03 1:17 ` [PATCH 2/4] x86/cpu: Describe hybrid CPUs in cpuinfo_x86 Ricardo Neri
2020-10-03 4:07 ` kernel test robot
2020-10-03 1:17 ` [PATCH 3/4] x86/cpu/intel: Add function to get name of hybrid CPU types Ricardo Neri
2020-10-03 1:17 ` [PATCH 4/4] x86/cpu/topology: Implement the CPU type sysfs interface Ricardo Neri
2020-10-03 3:33 ` Randy Dunlap
2020-10-03 5:28 ` kernel test robot
2020-10-03 8:55 ` Greg Kroah-Hartman
2020-10-06 1:05 ` Ricardo Neri [this message]
2020-10-03 8:49 ` [PATCH 0/4] drivers core: Introduce " Borislav Petkov
2020-10-06 0:27 ` Ricardo Neri
2020-10-06 8:51 ` Qais Yousef
2020-10-07 2:50 ` Ricardo Neri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201006010536.GE6041@ranerica-svr.sc.intel.com \
--to=ricardo.neri-calderon@linux.intel.com \
--cc=ak@linux.intel.com \
--cc=bp@suse.de \
--cc=dave.hansen@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=kan.liang@linux.intel.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=ravi.v.shankar@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).