Re: [PATCH 1/1] blk-snap - Block snapshot module This module implements snapshot and changed block tracking functionality. It is intended to create backup copies of any block devices without usage of device-mapper.

From: Sergei Shtepa <sergei.shtepa@veeam.com>
To: Konstantin Khlebnikov <koct9i@gmail.com>
Cc: Jens Axboe <axboe@kernel.dk>,
	"mchehab+huawei@kernel.org" <mchehab+huawei@kernel.org>,
	David Miller <davem@davemloft.net>,
	"robh@kernel.org" <robh@kernel.org>,
	"damien.lemoal@wdc.com" <damien.lemoal@wdc.com>,
	Jan Kara <jack@suse.cz>,
	"ming.lei@redhat.com" <ming.lei@redhat.com>,
	"steve@sk2.org" <steve@sk2.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	linux-kbuild <linux-kbuild@vger.kernel.org>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH 1/1] blk-snap - Block snapshot module This module implements snapshot and changed block tracking functionality. It is intended to create backup copies of any block devices without usage of device-mapper.
Date: Tue, 6 Oct 2020 11:43:32 +0300	[thread overview]
Message-ID: <20201006084332.GA9979@veeam.com> (raw)
In-Reply-To: <CALYGNiORw=DrKxoaoQPJP8TNM-S_W0Zdtpvra_eMs+Ri5f2P-g@mail.gmail.com>

Thanks for the answer.

Unfortunately, blk-rq-qos cannot be used efficiently for this purpose.
blk-rq-qos is good for collecting request queue processing metrics.
The level at which the interception is performed is too low - it happens 
after the device driver has already received the request for processing.

For the filter to work efficiently, we need to ensure that the interception
is performed on a higher level. It is required to put processing of 
multiple BIOs on hold while COW algorithm is being executed for them.
We must not be blocking the request processing queue, and also we would
like to avoid impacting the IO scheduler operations.

-- 
Sergei Shtepa
Veeam Software developer.