From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1D87C47095 for ; Wed, 7 Oct 2020 03:20:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 23A97208C3 for ; Wed, 7 Oct 2020 03:20:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="MFsCGRvp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727056AbgJGDUQ (ORCPT ); Tue, 6 Oct 2020 23:20:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726002AbgJGDUQ (ORCPT ); Tue, 6 Oct 2020 23:20:16 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB576C061755; Tue, 6 Oct 2020 20:20:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=3lLD0zvE4MJ6obA1X6t1ltm+Ls0OGSfFYsuDvjn+1S8=; b=MFsCGRvpNGRCh6eLvXW6qRDO6U G6brFP4dYd07RmCnkYA3fdM35fYCPeiKMMESZIx9O57f4aY5UNVSW6K24NAR2Xn/mj0zmCP+dI286 EpCC1FbhsCFYKQI0vz1pjzwR3gv/NZS8msguVo1g9yxnYqZy89Y5JNJRScdUyUiUk0+lnvcvifs7/ rb47ggI0zem2nvCvPMnSkCz2L19v0sKDFLUSM+bCUxO+rIcb275xOYiD3yFFcYy27sAzyffQlpRgN U4dNouLq2u8MEXdEQlIbeAp+P3DeNM9KYlenMPc18NUgV6yr2EVy4NFF8GaTakhdK+mlDea/lqYPI 99wlsaqw==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPzzx-0005dE-Db; Wed, 07 Oct 2020 03:20:13 +0000 Date: Wed, 7 Oct 2020 04:20:13 +0100 From: Matthew Wilcox To: jglisse@redhat.com Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Andrew Morton , Alexander Viro , Tejun Heo , Jan Kara , Josef Bacik Subject: Re: [PATCH 00/14] Small step toward KSM for file back page. Message-ID: <20201007032013.GS20115@casper.infradead.org> References: <20201007010603.3452458-1-jglisse@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201007010603.3452458-1-jglisse@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 06, 2020 at 09:05:49PM -0400, jglisse@redhat.com wrote: > The present patchset just add mapping argument to the various vfs call- > backs. It does not make use of that new parameter to avoid regression. > I am posting this whole things as small contain patchset as it is rather > big and i would like to make progress step by step. Well, that's the problem. This patch set is gigantic and unreviewable. And it has no benefits. The idea you present here was discussed at LSFMM in Utah and I recall absolutely nobody being in favour of it. You claim many wonderful features will be unlocked by this, but I think they can all be achieved without doing any of this very disruptive work. > 118 files changed, 722 insertions(+), 385 deletions(-) mmm.