From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3B3EC43467 for ; Thu, 8 Oct 2020 12:37:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 81AD22083B for ; Thu, 8 Oct 2020 12:37:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Kyrzom+2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730092AbgJHMh6 (ORCPT ); Thu, 8 Oct 2020 08:37:58 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:54653 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730084AbgJHMh6 (ORCPT ); Thu, 8 Oct 2020 08:37:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602160677; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8BwNT4iYD45Vztv7nysdJWnSG8XKP2AwXG1rPxDEm6s=; b=Kyrzom+2xwJfCqnnYof7rVXnLaB0U2e3dsOowZPAFUpgFjAWvVIm8oPNAAkTG1o66RyY6a Tg+lRLHiLdYyvER7iBRvcc1TfRHR0eByIk5C3a6HilrvgaqTqMN5f8cYNMprYG3UZQBeT0 FRc2mEw5cGwXnwCY24HYeQxtqXrap0s= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-49-irJx1NGON4yMAaVGgHGWHA-1; Thu, 08 Oct 2020 08:37:53 -0400 X-MC-Unique: irJx1NGON4yMAaVGgHGWHA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 123021019626; Thu, 8 Oct 2020 12:37:52 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.40.192.132]) by smtp.corp.redhat.com (Postfix) with SMTP id 9706F5D9D5; Thu, 8 Oct 2020 12:37:50 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Thu, 8 Oct 2020 14:37:51 +0200 (CEST) Date: Thu, 8 Oct 2020 14:37:49 +0200 From: Oleg Nesterov To: Jens Axboe Cc: linux-kernel@vger.kernel.org, io-uring@vger.kernel.org, peterz@infradead.org, tglx@linutronix.de Subject: Re: [PATCH 1/6] tracehook: clear TIF_NOTIFY_RESUME in tracehook_notify_resume() Message-ID: <20201008123748.GD9995@redhat.com> References: <20201005150438.6628-1-axboe@kernel.dk> <20201005150438.6628-2-axboe@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201005150438.6628-2-axboe@kernel.dk> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jens, sorry for delay.. On 10/05, Jens Axboe wrote: > > All the callers currently do this, clean it up and move the clearing > into tracehook_notify_resume() instead. To me this looks like a good cleanup regardless. Oleg.