From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: dmaengine@vger.kernel.org, "Allen Pais" <allen.lkml@gmail.com>,
"Romain Perier" <romain.perier@gmail.com>,
linux-kernel@vger.kernel.org, "Andreas Färber" <afaerber@suse.de>
Subject: Re: [PATCH 5/5] dmaengine: owl-dma: fix kernel-doc style for enum
Date: Thu, 8 Oct 2020 19:34:03 +0530 [thread overview]
Message-ID: <20201008140403.GB23649@linux> (raw)
In-Reply-To: <20201007083113.567559-6-vkoul@kernel.org>
On Wed, Oct 07, 2020 at 02:01:13PM +0530, Vinod Koul wrote:
> Driver doesn't use keyword enum for enum owl_dmadesc_offsets resulting
> in warning:
>
> drivers/dma/owl-dma.c:139: warning: cannot understand function prototype:
> 'enum owl_dmadesc_offsets '
>
> So add the keyword to fix it and also add documentation for missing
> OWL_DMADESC_SIZE
>
Do we really need to document the max value? Does it produce any warning?
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
> ---
> drivers/dma/owl-dma.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/dma/owl-dma.c b/drivers/dma/owl-dma.c
> index 331c8d8b10a3..9fede32641e9 100644
> --- a/drivers/dma/owl-dma.c
> +++ b/drivers/dma/owl-dma.c
> @@ -124,7 +124,7 @@
> #define FCNT_VAL 0x1
>
> /**
> - * owl_dmadesc_offsets - Describe DMA descriptor, hardware link
> + * enum owl_dmadesc_offsets - Describe DMA descriptor, hardware link
> * list for dma transfer
> * @OWL_DMADESC_NEXT_LLI: physical address of the next link list
> * @OWL_DMADESC_SADDR: source physical address
> @@ -135,6 +135,7 @@
> * @OWL_DMADESC_CTRLA: dma_mode and linklist ctrl config
> * @OWL_DMADESC_CTRLB: interrupt config
> * @OWL_DMADESC_CONST_NUM: data for constant fill
> + * @OWL_DMADESC_SIZE: max size of this enum
> */
> enum owl_dmadesc_offsets {
> OWL_DMADESC_NEXT_LLI = 0,
> --
> 2.26.2
>
next prev parent reply other threads:[~2020-10-08 14:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-07 8:31 [PATCH 0/5] Fix warning in dmaengine subsystem Vinod Koul
2020-10-07 8:31 ` [PATCH 1/5] dmaengine: altera-msgdma: fix kernel-doc style for tasklet Vinod Koul
2020-10-07 8:31 ` [PATCH 2/5] dmaengine: qcom: bam_dma: " Vinod Koul
2020-10-07 8:31 ` [PATCH 3/5] dmaengine: xilinx_dma: " Vinod Koul
2020-10-07 8:36 ` Michal Simek
2020-10-07 8:31 ` [PATCH 4/5] dmaengine: zynqmp_dma: " Vinod Koul
2020-10-07 8:36 ` Michal Simek
2020-10-07 8:31 ` [PATCH 5/5] dmaengine: owl-dma: fix kernel-doc style for enum Vinod Koul
2020-10-08 14:04 ` Manivannan Sadhasivam [this message]
2020-10-09 4:18 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201008140403.GB23649@linux \
--to=manivannan.sadhasivam@linaro.org \
--cc=afaerber@suse.de \
--cc=allen.lkml@gmail.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=romain.perier@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).