From: Maxime Ripard <maxime@cerno.tech>
To: Michal Suchanek <msuchanek@suse.de>
Cc: linux-arm-kernel@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: sun8i: h2+: Enable optional SPI flash on Orange Pi Zero board
Date: Thu, 8 Oct 2020 17:13:15 +0200 [thread overview]
Message-ID: <20201008151315.v3geykbs6musl4wq@gilmour.lan> (raw)
In-Reply-To: <20200929083025.2089-1-msuchanek@suse.de>
[-- Attachment #1: Type: text/plain, Size: 1245 bytes --]
Hi,
On Tue, Sep 29, 2020 at 10:30:25AM +0200, Michal Suchanek wrote:
> The flash is present on all new boards and users went out of their way
> to add it on the old ones.
>
> Enabling it makes a more reasonable default.
>
> Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> ---
> arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts b/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts
> index f19ed981da9d..061d295bbba7 100644
> --- a/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts
> +++ b/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts
> @@ -163,8 +163,8 @@ &ohci1 {
> };
>
> &spi0 {
> - /* Disable SPI NOR by default: it optional on Orange Pi Zero boards */
> - status = "disabled";
> + /* Enable optional SPI NOR by default */
> + status = "okay";
>
> flash@0 {
> #address-cells = <1>;
Unfortunately, it's optional, so there's really no reason to enable it
all the time. If it's troublesome to users, then the distros or vendors
should make the changes necessary to the hardware, bootloader or their
documentation to make it easier for those users.
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2020-10-08 15:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 8:30 [PATCH] ARM: dts: sun8i: h2+: Enable optional SPI flash on Orange Pi Zero board Michal Suchanek
2020-10-08 15:13 ` Maxime Ripard [this message]
2020-10-08 16:02 ` Michal Suchánek
2020-10-08 17:14 ` Maxime Ripard
2020-10-08 17:40 ` Michal Suchánek
2020-10-12 15:35 ` Maxime Ripard
2020-10-12 17:03 ` Michal Suchánek
2020-10-19 10:08 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201008151315.v3geykbs6musl4wq@gilmour.lan \
--to=maxime@cerno.tech \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=msuchanek@suse.de \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).