From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64F08C433E7 for ; Fri, 9 Oct 2020 15:20:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2817122227 for ; Fri, 9 Oct 2020 15:20:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389221AbgJIPU4 (ORCPT ); Fri, 9 Oct 2020 11:20:56 -0400 Received: from foss.arm.com ([217.140.110.172]:53562 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387664AbgJIPUz (ORCPT ); Fri, 9 Oct 2020 11:20:55 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A3C941063; Fri, 9 Oct 2020 08:20:54 -0700 (PDT) Received: from bogus (unknown [10.57.53.233]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7C6803F70D; Fri, 9 Oct 2020 08:20:53 -0700 (PDT) Date: Fri, 9 Oct 2020 16:20:51 +0100 From: Sudeep Holla To: Etienne Carriere Cc: linux-kernel@vger.kernel.org, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Cristian Marussi , Vincent Guittot , Souvik Chakravarty Subject: Re: [PATCH 2/5] firmware: arm_scmi: fix transfer missing re-initialization Message-ID: <20201009152051.qjxdg3goqqmdtr74@bogus> References: <20201008143722.21888-1-etienne.carriere@linaro.org> <20201008143722.21888-2-etienne.carriere@linaro.org> <20201008211804.soegjqsvmsgfmcne@bogus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20171215 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 09, 2020 at 02:38:16PM +0200, Etienne Carriere wrote: > On Thu, 8 Oct 2020 at 23:18, Sudeep Holla wrote: > > > > On Thu, Oct 08, 2020 at 04:37:19PM +0200, Etienne Carriere wrote: > > > Implement helper function scmi_do_xfer_again() to process consecutive > > > transfers that are initialized only once with scmi_xfer_get_init() > > > and hence get the pool completion and responses message length not > > > reloaded regarding last completed transfer. > > > > > > Signed-off-by: Etienne Carriere > > > --- > > > drivers/firmware/arm_scmi/base.c | 2 +- > > > drivers/firmware/arm_scmi/clock.c | 2 +- > > > drivers/firmware/arm_scmi/common.h | 2 ++ > > > drivers/firmware/arm_scmi/driver.c | 10 ++++++++++ > > > drivers/firmware/arm_scmi/perf.c | 2 +- > > > drivers/firmware/arm_scmi/sensors.c | 2 +- > > > 6 files changed, 16 insertions(+), 4 deletions(-) > > > > > > diff --git a/drivers/firmware/arm_scmi/base.c b/drivers/firmware/arm_scmi/base.c > > > index 9853bd3c4d45..508f214baa1b 100644 > > > --- a/drivers/firmware/arm_scmi/base.c > > > +++ b/drivers/firmware/arm_scmi/base.c > > > @@ -183,7 +183,7 @@ static int scmi_base_implementation_list_get(const struct scmi_handle *handle, > > > /* Set the number of protocols to be skipped/already read */ > > > *num_skip = cpu_to_le32(tot_num_ret); > > > > > > - ret = scmi_do_xfer(handle, t); > > > + ret = scmi_do_xfer_again(handle, t); > > > if (ret) > > > break; > > > > > > diff --git a/drivers/firmware/arm_scmi/clock.c b/drivers/firmware/arm_scmi/clock.c > > > index c1cfe3ee3d55..9bb54c1a8d55 100644 > > > --- a/drivers/firmware/arm_scmi/clock.c > > > +++ b/drivers/firmware/arm_scmi/clock.c > > > @@ -161,7 +161,7 @@ scmi_clock_describe_rates_get(const struct scmi_handle *handle, u32 clk_id, > > > /* Set the number of rates to be skipped/already read */ > > > clk_desc->rate_index = cpu_to_le32(tot_rate_cnt); > > > > > > - ret = scmi_do_xfer(handle, t); > > > + ret = scmi_do_xfer_again(handle, t); > > > if (ret) > > > goto err; > > > > > > diff --git a/drivers/firmware/arm_scmi/common.h b/drivers/firmware/arm_scmi/common.h > > > index 37fb583f1bf5..6d4eea7b0f3e 100644 > > > --- a/drivers/firmware/arm_scmi/common.h > > > +++ b/drivers/firmware/arm_scmi/common.h > > > @@ -143,6 +143,8 @@ struct scmi_xfer { > > > > > > void scmi_xfer_put(const struct scmi_handle *h, struct scmi_xfer *xfer); > > > int scmi_do_xfer(const struct scmi_handle *h, struct scmi_xfer *xfer); > > > +int scmi_do_xfer_again(const struct scmi_handle *handle, > > > + struct scmi_xfer *xfer); > > > int scmi_do_xfer_with_response(const struct scmi_handle *h, > > > struct scmi_xfer *xfer); > > > int scmi_xfer_get_init(const struct scmi_handle *h, u8 msg_id, u8 prot_id, > > > diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c > > > index c5dea87edf8f..887cb8249db0 100644 > > > --- a/drivers/firmware/arm_scmi/driver.c > > > +++ b/drivers/firmware/arm_scmi/driver.c > > > @@ -402,6 +402,16 @@ int scmi_do_xfer(const struct scmi_handle *handle, struct scmi_xfer *xfer) > > > return ret; > > > } > > > > > > +int scmi_do_xfer_again(const struct scmi_handle *handle, struct scmi_xfer *xfer) > > > +{ > > > + struct scmi_info *info = handle_to_scmi_info(handle); > > > + > > > + xfer->rx.len = info->desc->max_msg_size; > > > > I am tempted to just have helper for above and use it where needed. > > Or may be I just don't like the name of the function, how about > > scmi_do_xfer_rxlen_reinit or anything else. Suggestions ? > > I think a smoother way would be that scmi_do_xfer() initializes > both > xfer->rx.len = info->desc->max_msg_size Possibly > and > xfer->hdr.poll_completion = false > instead of doing that from scmi_xfer_get_init(). > > > > > > + xfer->hdr.poll_completion = false; > > > > Do we really need the above ? > > I think so. Once a transfer is completed, poll_completion is true. Where and how ? By default it is always false and it can be set to true only by perf set/get calls. So I still see no need for this. -- Regards, Sudeep