linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Yafang Shao <laoar.shao@gmail.com>
Cc: mingo@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tracing: add tgid into common field
Date: Tue, 13 Oct 2020 09:05:11 -0400	[thread overview]
Message-ID: <20201013090511.1f2f71f6@gandalf.local.home> (raw)
In-Reply-To: <20201013055454.52634-1-laoar.shao@gmail.com>

On Tue, 13 Oct 2020 13:54:54 +0800
Yafang Shao <laoar.shao@gmail.com> wrote:

> --- a/include/linux/trace_events.h
> +++ b/include/linux/trace_events.h
> @@ -67,6 +67,7 @@ struct trace_entry {
>  	unsigned char		flags;
>  	unsigned char		preempt_count;
>  	int			pid;
> +	int			tgid;
>  };
>  

Sorry, this adds another 4 bytes to *every* event, if you want it to or
not. I'd rather have some ways to remove fields from this header, and not
add more to it.

I can't take this patch.

-- Steve

  reply	other threads:[~2020-10-13 13:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-13  5:54 [PATCH] tracing: add tgid into common field Yafang Shao
2020-10-13 13:05 ` Steven Rostedt [this message]
2020-10-13 14:48   ` Yafang Shao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201013090511.1f2f71f6@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=laoar.shao@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).