From: "Paul E. McKenney" <paulmck@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Josh Triplett <josh@joshtriplett.org>,
Steven Rostedt <rostedt@goodmis.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Joel Fernandes <joel@joelfernandes.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
rcu@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rcu-tasks: Add missing inline to show_rcu_tasks_rude_gp_kthread() dummy
Date: Sat, 17 Oct 2020 08:38:26 -0700 [thread overview]
Message-ID: <20201017153826.GA3249@paulmck-ThinkPad-P72> (raw)
In-Reply-To: <20201016103144.23491-1-geert@linux-m68k.org>
On Fri, Oct 16, 2020 at 12:31:44PM +0200, Geert Uytterhoeven wrote:
> If CONFIG_TINY_RCU=y:
>
> In file included from kernel/rcu/update.c:591:
> kernel/rcu/tasks.h:710:13: warning: ‘show_rcu_tasks_rude_gp_kthread’ defined but not used [-Wunused-function]
> static void show_rcu_tasks_rude_gp_kthread(void) {}
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Fix this by marking show_rcu_tasks_rude_gp_kthread() inline.
>
> Fixes: e21408ceec2de5be ("rcu-tasks: Add RCU tasks to rcutorture writer stall output")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Good catch, but commit 2cf0c4b5 ("rcutorture: Make grace-period kthread
report match RCU flavor being tested") beat you to it, though apparently
by accident.
Either way, thank you for your time and attention!
Thanx, Paul
> ---
> Exposed by commit 1e6c62a882155772 ("bpf: Introduce sleepable BPF
> programs"), which selects TASKS_TRACE_RCU.
> ---
> kernel/rcu/tasks.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/rcu/tasks.h b/kernel/rcu/tasks.h
> index d5d9f2d03e8a0ac9..8c290cc45e6fc63a 100644
> --- a/kernel/rcu/tasks.h
> +++ b/kernel/rcu/tasks.h
> @@ -707,7 +707,7 @@ static void show_rcu_tasks_rude_gp_kthread(void)
> #endif /* #ifndef CONFIG_TINY_RCU */
>
> #else /* #ifdef CONFIG_TASKS_RUDE_RCU */
> -static void show_rcu_tasks_rude_gp_kthread(void) {}
> +static inline void show_rcu_tasks_rude_gp_kthread(void) {}
> #endif /* #else #ifdef CONFIG_TASKS_RUDE_RCU */
>
> ////////////////////////////////////////////////////////////////////////
> --
> 2.17.1
>
prev parent reply other threads:[~2020-10-17 15:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 10:31 [PATCH] rcu-tasks: Add missing inline to show_rcu_tasks_rude_gp_kthread() dummy Geert Uytterhoeven
2020-10-17 15:38 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201017153826.GA3249@paulmck-ThinkPad-P72 \
--to=paulmck@kernel.org \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=geert@linux-m68k.org \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).